New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bots should log instance number #3673

Open
DanVanAtta opened this Issue Aug 1, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@DanVanAtta
Member

DanVanAtta commented Aug 1, 2018

Below is a small log sample produced by bots:

Aug 01 05:32:47 bot70_nj_4g_usa run_bot.sh: THREAD DUMP
Aug 01 05:32:47 bot70_nj_4g_usa run_bot.sh: thread<979,Triplea, start server game>
Aug 01 05:32:47 bot70_nj_4g_usa run_bot.sh: state:RUNNABLE
Aug 01 05:32:47 bot70_nj_4g_usa run_bot.sh:   sun.management.ThreadImpl.getThreadInfo1(Native Method)
Aug 01 05:32:47 bot70_nj_4g_usa run_bot.sh:   sun.management.ThreadImpl.getThreadInfo(ThreadImpl.java:176)

We run multiple bot instances per server, from the above we cannot tell which bot instance had the problem. This makes it hard to correlate a problem in logs with a report like "bot 702 crashed today at 10am". The desired outcome of this issue is that we update logging so that bots will print their "instance name", so we could have something like:

Aug 01 05:32:47 <bot702> bot70_nj_4g_usa run_bot.sh: THREAD DUMP
Aug 01 05:32:47 <bot702> bot70_nj_4g_usa run_bot.sh: thread<979,Triplea, start server game>
Aug 01 05:32:47 <bot702> bot70_nj_4g_usa run_bot.sh: state:RUNNABLE
Aug 01 05:32:47 <bot702> bot70_nj_4g_usa run_bot.sh:   sun.management.ThreadImpl.getThreadInfo1(Native Method)
Aug 01 05:32:47 <bot702> bot70_nj_4g_usa run_bot.sh:   sun.management.ThreadImpl.getThreadInfo(ThreadImpl.java:176)

@DanVanAtta DanVanAtta changed the title from Bots should lock instance number to Bots should log instance number Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment