Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Display Overbuy Rule to Game Players #3767
Task here is to add a display/label/notification of how over-buy is handled in a given game. Similar perhaps to game help notes, it'll be something you can click (or maybe a help button on purchase window), to then read about how overbuy is handled, whether it is refunded, carried over, or lost.
Currently a user would have to experiment with this or find it out from the map XML. The feedback and notification of which rule is being used is missing from the UI.
changed the title from
Overbuy Handling Display
Display Overbuy Rule to Game Players
Aug 9, 2018
This was referenced
Aug 9, 2018
While there the handling of overbuys should be tested and corrected map-wise.
Good points @panther2 , for each of those problems we should create a map bug. If/when we fix this issue, it'll be easier to identify those maps, we'll see what the refund policy is and it'll be easier to know if it's wrong compared to testing the hard way which refund policies are used on which maps.
Good idea, but this topic should be reformulated on more general terms, I believe, as this property/rule is just "one of".
For example, in 270BC people usually get surprised that city don't block blitz, as all rulesets from v2 onwards do.
I guess it would be good having something after unit help in which to see all the properties that are currently set "true" for that game, like power users can already do by delving into the xml.
Tho there are a lot of properties that are or could be documented in the unit help info; for example, if a factory blocks blitz or not could be clarified there. So maybe those should not be listed somewhere else too, or it might be redundant. On the other hand, in the moment you cannot decide if this or that capturable unit blocks blitz, but you can only set for them all the same, then the redundancy may be to have it part of the specific units info.
The thing can stay in "Help", in between of "Unit Help" and "Game Notes".
Alternatively, a button in Game/Map Options to show all the properties, not just the editable ones.
p.s.: "Map Options" should be named "Game Options", or just "Options", since it is part of the "Game" submenu.
p.p.s.: On the other hand, showing up all the properties may be not polished enough, for regular users, especially in cases like WWIIv3, in which you would, then, see stuff like:
I'm just saying that I suggest reformulating this issue as to generally display all relevant properties to the users (comprising over-buy), but also pointing out that just showing up all properties as they are is not very polished or really informative at all in all cases.
I don't think that will be effective, it also increase the scope of this task. A list of yes/no votes would be okay, but this is not the issue/task to do that. This task is specific and actionable, the scope is well defined. We should not muddy that up; any further discussion of additional tasks should go elsewhere. Each of those rules are complicated enough that in code we'll have to do each one carefully each on their own. Discussing all of them at once is not going to help that and will not get us very fast, instead cut many issues and we'll close them down quickly as we knock out the task or decide we will not do it. We do not want any non-discussion tasks running for longer than a 4 weeks, tracking tasks are meant to be short and sweet, background context ideally behind a link unless the topic needed lots of discussion for requirements.
Please create a new ticket to report this player confusion, this is a UX problem. The fix here is not at all on labeling how the game handles purchase that cannot be placed.
Yup, that is in unit help though, please create a ticket for that and the properties you would like to see documented in that window.
My recommendation is for the unit icon to try and help solve that on a map by map basis, give a special symbol for blitz. There could be maybe a game engine feature here. This is a better topic for forum though.
.... this has nothing to do with how the game handles purchase, re-reading this topic will take time and reading items off-topic is not helpful for identifying what requirements we need to support and then deciding how to update the code to do that.
I think that is a very good idea, but that would also deserve it's own feature-request/forum post.
Another forum post or github issue that should be created
This is crossing threads, https://forums.triplea-game.org/topic/912/a-general-way-to-define-infinite/15
Please keep the topic in one place to avoid confusion. In general, please prefer short and on-topic issues that are focused.
Ok if you prefer keeping it focused, that's your call. Just to make sure there is no miscommunication, what I was saying is that a power user currently can get the info by opening the xml and looking if there is this property set true:
That is now currently visible in Map Options only if editable.
So this issue could be solved by letting regular users see all the properties (thus comprising this particular one), without having to open the xml. Not saying this is the best way to solve this specific case.