Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight empty bots #2506

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@RoiEXLab
Copy link
Member

RoiEXLab commented Oct 15, 2017

Per https://forums.triplea-game.org/topic/342/highlight-waiting-for-players-on-lobby-games
A really good and easy-to-implement idea IMO, the color isn't final
screenshot

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 15, 2017

Codecov Report

Merging #2506 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2506      +/-   ##
============================================
- Coverage     20.53%   20.52%   -0.01%     
+ Complexity     5834     5833       -1     
============================================
  Files           830      830              
  Lines         73606    73609       +3     
  Branches      12402    12404       +2     
============================================
- Hits          15113    15110       -3     
- Misses        56410    56414       +4     
- Partials       2083     2085       +2
Impacted Files Coverage Δ Complexity Δ
...trategy/engine/lobby/client/ui/LobbyGameTable.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rategy/triplea/attachments/UnitTypeComparator.java 35.71% <0%> (-7.15%) 10% <0%> (-1%)
...tegy/triplea/oddsCalculator/ta/OddsCalculator.java 44.06% <0%> (-0.32%) 13% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f348c5...c0ed2ff. Read the comment docs.

@DanVanAtta

This comment has been minimized.

Copy link
Member

DanVanAtta commented Oct 16, 2017

Interesting idea. Overall, I'd like for us to establish a plan for what an end-vision would look like. Highlighting empty bots all the time might not be ideal. There is for certain a use case of "I need an empty" bot that this would help satisfy. I think solving that use case would go in hand in hand with the use case "has anyone hosted but not yet started a game?". An add-on to that would be map preferences, then dice preference as well. Sometimes as well people are interested in specific hosts, and whether you have a save game vs that person.

I think at question most is how someone would turn on and off these features, and how we could also present some additional filters without things being cluttered. A drop down with a set of check boxes and hot keys assigned might work. A pull out panel menu from the side of the screen could also be an option, just as well as some more old school menu bar checkboxes.

@prastle

This comment has been minimized.

@RoiEXLab

This comment has been minimized.

Copy link
Member Author

RoiEXLab commented Oct 18, 2017

Closing until we work out a final idea.
Once we agreed on something I'll submit a fresh PR.

@RoiEXLab RoiEXLab closed this Oct 18, 2017

@Heppisorus

This comment has been minimized.

Copy link
Contributor

Heppisorus commented Oct 19, 2017

lobby layout

Here's some food for thought.

First... I think we could eliminate EV (Engine Version) column as it seems truly redundant since you can only be on one version.

Second... I think we can eliminate the B (Bot) column since each Bot is labelled a Bot in the Host column.

The rest is really just building on some of the thoughts floating around already.

Highlighting game currently waiting for players... which should really only be highlighted if there are any players in the Bot or host at all.

Adding a series of icons you can select for the Settings box. Low Luck... Dice... Tech... no Tech... etc.

And a Tourney box to identify games that are part of an ongoing tourney.

Just some idea's.

@Heppisorus

This comment has been minimized.

Copy link
Contributor

Heppisorus commented Oct 19, 2017

To be honest the suggested "Settings" Column should have icons that auto populate based on the selections you have made in the Bot and in the "Map Options" windows. However I was hesitant to suggest this as I have not investigated as to whether all the maps have things like "Bid Phase" included inside the map themselves. Thus potentially causing issues for the Setting box if you cannot manually input certain parameters. Nor was I sure how much work would be involved in such a venture.

After-all, something like a "Settings" column is only valuable if it... (A) It displays info in a consistent manner. (ie. chosen options appear in the same order all the time). (B) The institution of these options do not require extra work from the participant. (ie. You select the options you want to play with inside the Bot and they "magically" appear on the "Settings" column in the lobby).

@Heppisorus

This comment has been minimized.

Copy link
Contributor

Heppisorus commented Oct 19, 2017

Last point I have always wondered about is the value of the "Started" column. I have personally never looked at it and I have never understood how it is a pertinent or valuable item. I generally look at the: game type, number of players and the round they are in. Seems to me as though we could eliminate that column as well in order to accommodate far more valuable and pertinent information.

That being said, I have no idea whether it means anything to anyone else who plays on the lobby.

I mention this because it reminds me of the reason they never put clocks in a casino. The proprietor does not want you to know what time it is... nor how long you have been playing. Lest you make a prudent decision to take a break or stop playing.

@Heppisorus

This comment has been minimized.

Copy link
Contributor

Heppisorus commented Oct 19, 2017

Bearing in mind my motivations to remove the Started column are based on the need for clarity and space for more important info., rather than for more nefarious motives of organized gambling businesses.

@DanVanAtta

This comment has been minimized.

Copy link
Member

DanVanAtta commented Oct 20, 2017

Also a good suggestion I think to remove the 'started' column. I vaguely recall once or twice it being useful, but you can infer how long a game has been running by the game round. The kicker for me is that I don't believe the time zone info of started is correct, I've the perception that time zones are mixed in the display, so it's hardly useful from that perspective. Rather than fix/verify time zones, would make sense IMO to whack the column instead and remove it.

@Heppisorus

This comment has been minimized.

Copy link
Contributor

Heppisorus commented Oct 20, 2017

Here is a more refined version of my thoughts for the use of space if we remove some of the less important and redundant information.
lobby layout 2

Couple follow up things to consider about these proposed changes...

  1. Adding the names of the players currently in a game will achieve 2 things... a) It will eliminate people joining and leaving games frequently trying to find friends. b) Will make it much easier for people to find the players they have a match with c) It will make the MODS job much easier when trying to boot ghost players and track down trouble makers and trolls.

  2. The fixed icons for game feature could have a hover feature so that when you hover over the icons it would tell you what they are... ie. "Scramble rules in effect".

I realize this might all seem ambitious... so take the suggestions for what they are worth. Just throwing idea's out there to cultivate more thought around what would be great features for all of us.

@RoiEXLab

This comment has been minimized.

Copy link
Member Author

RoiEXLab commented Oct 20, 2017

@Heppisorus It's a shame you aren't part of the developer team ^^
I really like your suggestion, hover overlays will be tricky, but the rest should be feasible to implement (I don't know how much information we have about the bots before actually joining them, might require some breaking changes)

@Heppisorus

This comment has been minimized.

Copy link
Contributor

Heppisorus commented Oct 20, 2017

@Heppisorus

This comment has been minimized.

Copy link
Contributor

Heppisorus commented Oct 20, 2017

BTW an easy work around (or even in-term solution) to the hover issue is to simply put a guide inside the help tab.

Realistically if we do a good job of making the icons visually identifiable to translate to a rule or setting (my examples are very quick and rudimentary ) ... then it would mean that people will grow accustom to their meaning (and position) fairly quickly. It would only be for some of the games with many variable settings (ie. Global) that people would ever really have to reference the chart.

Truth be told we don't need any info on unoccupied Bots. Their settings can disappear if no one is in them. In fact that would be even more effective as another way to distinguish occupied Bots waiting for more players and one's available for a new or different game.

@RoiEXLab RoiEXLab deleted the RoiEXLab:highlight-empty-bots branch Oct 20, 2017

@beelee1

This comment has been minimized.

Copy link
Contributor

beelee1 commented Oct 23, 2017

Like the only highlight when people are actually waiting Hepps. I know there is a lot that can be improved but would be nice to see this for starters while the rest gets hashed out.

@beelee1

This comment has been minimized.

Copy link
Contributor

beelee1 commented Jan 2, 2018

Here's a latest thought

Was thinking that you could have the games that someone is in and looking for players be as follows:

Using Global 40 colors

Canadian Red = Expert

French Blue = Intermediate

UK Khaki = Novice

Would be nice to use the underlayer ? like it looks in the map so it doesn't appear cartoonish. Or maybe the writing would be enough to prevent that.

Then use USA Green for games that are in progress. Leave the games with nobody in them the way it is now.

Just a thought : )

@prastle

This comment has been minimized.

Copy link
Contributor

prastle commented Jan 3, 2018

Keep it alive @beelee1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.