Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-game downloaded map unzip support #3339

Merged
merged 4 commits into from Apr 4, 2018
Merged

Conversation

@ron-murhammer
Copy link
Member

ron-murhammer commented Apr 1, 2018

Addresses https://forums.triplea-game.org/topic/706/open-unzipped-map

Functional Changes

  • Adds map directory support for unzipped maps downloaded from in-game in the form of:
    --- "map_name-master/map"
    --- "map_name-master"

Testing

  • Unzipped any map that was downloaded from in-game for example "blue_vs_gray-master.zip" to "blue_vs_gray-master/map"
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 1, 2018

Codecov Report

Merging #3339 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3339      +/-   ##
============================================
+ Coverage     21.94%   21.95%   +<.01%     
- Complexity     5885     5887       +2     
============================================
  Files           834      834              
  Lines         72168    72171       +3     
  Branches      11665    11665              
============================================
+ Hits          15838    15845       +7     
+ Misses        54233    54231       -2     
+ Partials       2097     2095       -2
Impacted Files Coverage Δ Complexity Δ
...in/java/games/strategy/triplea/ResourceLoader.java 19.78% <83.33%> (+5%) 7 <1> (+1) ⬆️
.../src/main/java/games/strategy/net/nio/Decoder.java 72.82% <0%> (-1.09%) 24% <0%> (-1%)
.../strategy/triplea/odds/calculator/DummyPlayer.java 36.36% <0%> (+1.13%) 10% <0%> (+1%) ⬆️
...rategy/triplea/attachments/UnitTypeComparator.java 53.84% <0%> (+7.69%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e9d2ff...4ca6e4e. Read the comment docs.

@prastle

This comment has been minimized.

Copy link
Contributor

prastle commented Apr 1, 2018

TY Nice Job!

@RoiEXLab RoiEXLab merged commit 43f2d19 into master Apr 4, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@RoiEXLab RoiEXLab deleted the Add_Github_Map_Unzip_Support branch Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.