Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions during game #4706

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@RoiEXLab
Copy link
Member

RoiEXLab commented Feb 23, 2019

Overview

This fixes the exception reported in https://forums.triplea-game.org/topic/1216/2-battle-results-workers-aborted-by-exception and an exception that occurred after fixing the first exception.

Functional Changes

Bug Fix.

Manual Testing Performed

I verified no Exception occurs now.

@RoiEXLab RoiEXLab requested a review from ron-murhammer Feb 23, 2019

@RoiEXLab

This comment has been minimized.

Copy link
Member Author

RoiEXLab commented Feb 23, 2019

@ron-murhammer I only focused on fixing the exceptions. In case you're familiar with the code affected I'd appreciate if you could point out potential different fixes that might result in a clearly defined behaviour.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 23, 2019

Codecov Report

Merging #4706 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4706      +/-   ##
============================================
+ Coverage     23.26%   23.26%   +<.01%     
- Complexity     6217     6219       +2     
============================================
  Files           872      872              
  Lines         70441    70442       +1     
  Branches      11264    11265       +1     
============================================
+ Hits          16385    16387       +2     
  Misses        52003    52003              
+ Partials       2053     2052       -1
Impacted Files Coverage Δ Complexity Δ
...java/games/strategy/triplea/delegate/DiceRoll.java 64.73% <0%> (-0.21%) 140 <0> (ø)
...es/strategy/triplea/delegate/BattleCalculator.java 52.53% <100%> (-0.1%) 75 <0> (ø)
.../strategy/triplea/odds/calculator/DummyPlayer.java 35.95% <0%> (+1.12%) 10% <0%> (+1%) ⬆️
...rategy/triplea/attachments/UnitTypeComparator.java 53.84% <0%> (+7.69%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1088267...7a568d1. Read the comment docs.

@ron-murhammer ron-murhammer merged commit 4f89eba into triplea-game:master Feb 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RoiEXLab RoiEXLab deleted the RoiEXLab:fix-exception branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.