Add: Update unit_scroller to have a unit_sleep button #5036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit sleep will auto-skip a unit until it has been moved. Useful for example for units that are on islands or AA guns. In this update the old unit-skip image, a moon, is renamed and re-used to be the unit sleep icon. A new 'checkmark' icon image is used for skip. Otherwise this feature update adds a second button next to the unit skip button for the unit sleep action.
RoiEXLab
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unit sleep will auto-skip a unit until it has been moved. Useful for example for units that are on islands or AA guns.
In this update the old unit-skip image, a moon, is renamed and re-used to be the unit sleep icon. A new 'checkmark' icon image is used for skip. Otherwise this feature update adds a second button next to the unit skip button for the unit sleep action.
Functional Changes
[ ] New map or map update
[ ] New Feature
[X] Feature update or enhancement
[ ] Code Removal
[ ] Code Cleanup or refactor
[ ] Configuration Change
[ ] Bug fix
User facing changes
Testing
[ ] Covered by existing automated tests
[ ] Covered by newly added automated tests
[X] Manually tested
[ ] No testing done
Manual Testing
Started a revised game, slept all Russian units. Then moved a couple units and verified they showed as movable during non-combat. Also verified they were not highlighted with F key. Then cycled turns back to Russia and verified sleeping units were still sleeping.
Screens Shots
Before
After
Additional Review Notes