Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Targets Including Dead Units Bug #5933

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@ron-murhammer
Copy link
Member

ron-murhammer commented Feb 13, 2020

Fix #5916. Now that multiple Fire objects are generated with varying targets for the isSuicide improvements, need to ensure to remove any already killed units before selecting casualties since the attackable units might include already killed units.

Functional Changes

[] New map or map update
[] New Feature
[] Feature update or enhancement
[] Feature Removal
[] Code Cleanup or refactor
[] Configuration Change
[x] Problem fix: #5916
[] Other:

Testing

[x] Manual testing done

Tested on G40 first turn Germany as that consistently threw the error during the AI's turn as they almost always have a sea battle where you have air that can't target subs fire before the rest.

@codeclimate

This comment has been minimized.

Copy link

codeclimate bot commented Feb 13, 2020

Code Climate has analyzed commit acccfab and detected 0 issues on this pull request.

View more on Code Climate.

@ron-murhammer ron-murhammer merged commit c81c127 into master Feb 13, 2020
16 checks passed
16 checks passed
build
Details
LGTM analysis: Java No new or fixed alerts
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (triplea-game) No manifest changes detected
security/snyk - game-core/build.gradle (triplea-game) No manifest changes detected
security/snyk - game-headed/build.gradle (triplea-game) No manifest changes detected
security/snyk - game-headless/build.gradle (triplea-game) No manifest changes detected
security/snyk - http-clients/build.gradle (triplea-game) No manifest changes detected
security/snyk - http-server/build.gradle (triplea-game) No manifest changes detected
security/snyk - java-extras/build.gradle (triplea-game) No manifest changes detected
security/snyk - lobby-db/build.gradle (triplea-game) No manifest changes detected
security/snyk - smoke-testing/build.gradle (triplea-game) No manifest changes detected
security/snyk - swing-lib/build.gradle (triplea-game) No manifest changes detected
security/snyk - test-common/build.gradle (triplea-game) No manifest changes detected
@ron-murhammer ron-murhammer deleted the Fix_Targets_Including_Dead_Units_Bug branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.