Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Addresses externalinterface issues in some IE flash player versions. …

…Fix #2529891
  • Loading branch information...
commit d8d50390f646a717c7e9a52ce551b548321380a9 1 parent 2929ce0
@tripp authored
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/swf/js/swf.js
View
4 src/swf/js/swf.js
@@ -104,8 +104,8 @@ function SWF (p_oElement /*:String*/, swfURL /*:String*/, p_oAttributes /*:Objec
}
objstring += "</object>";
- oElement.setContent(objstring);
-
+ oElement._node.innerHTML = objstring;
+
this._swf = Node.one("#" + _id);
} else {
/**

5 comments on commit d8d5039

@lsmith

oElement.set('innerHTML', objstring)

Is that Hungarian notation?

Have you traced the issue through Node.setContent to the DOM methods used?

@lsmith

Is it possible that DOM.createHTML is behaving badly for <object>s?
Or that the markup string generated has a typo, resulting in unpredictable browser behavior?

@tripp
Owner

It seems to be less of a createHTML behaving badly and more of an IE/FlashPlayer behaving badly. I run into the same issues, if I construct the object and its children using document.createElement and appendChild.

@tripp
Owner

Sorry Luke, I missed seeing your first comment. You're right: oElement.set("innerHTML", objstring) would be better.
Yes, I did trace through the node.setContent. It seems the node is created using innerHTML on a dummy div and then that node is append to the dom. For some reason which I have not figured out yet, only adding the dom string with innerHTML seems to work as it should.

@lsmith

Ok, add a comment detailing why set('innerHTML'...) is used instead of setHTML (formerly setContent) and this LGTM.

Please sign in to comment.
Something went wrong with that request. Please try again.