Albert Lee trisk

Organizations

@illumos-gsoc
trisk commented on issue docker/docker#5157
@trisk

Buildroot-based systems exhibit this issue (#3825) on docker pull. The reason appears to be that none of paths for CA certificate files in src/cryp…

trisk commented on pull request zfsonlinux/zfs#3299
@trisk

Gotcha. I was wondering about the use of umem_alloc with no umem_nofail_callback. zfs_alloc seems like it would be suitable here.

trisk commented on commit ryao/zfs@acb258e23f
@trisk

Though I guess it's consistent with zfs list, there isn't a real reason for saving 4 characters for non-interactive use.

trisk commented on pull request mistifyio/go-zfs#31
@trisk

Seems like this would extend logically to Mount and replace the properties map as well? I think our consumers would be okay with updating that and D…

trisk commented on issue dnschneid/crouton#713
@trisk

@theblacklion I'm working on new code in croutonxi2event to handle scrolling direction changes, but I can try a merge of the existing script changes.

trisk pushed to master at mistifyio/docs
@trisk
  • cdc3f47
    Initial import of containers and OpenZFS resiliency docs
trisk pushed to master at mistifyio/docs
@trisk
  • 15fe8f2
    Initial import of containers and OpenZFS resiliency docs.
trisk commented on pull request zfsonlinux/zfs#3299
@trisk

General cstyle nit: When using a non-boolean expression in a condition it's preferred to explicitly compare to 0. if ((error = ...) != 0) if (nvlis…

trisk commented on pull request zfsonlinux/zfs#3299
@trisk

Any reason for the explicit umem_alloc() here? AFAIK this is the only call in libzfs that doesn't use a specific cache.

trisk commented on pull request zfsonlinux/zfs#3299
@trisk

Is this clear_received_props subject to a a race with another set_props?

trisk commented on pull request zfsonlinux/zfs#3299
@trisk

Could be simplified as: zprop_source_t source = ZPROP_SRC_LOCAL; ... if (nvlist_exists(opts, "received")) { source = ZPROP_SRC_RECEIVED;

trisk commented on pull request zfsonlinux/zfs#3299
@trisk

This is the only option name with an underscore.

trisk commented on pull request mistifyio/mistify-agent#40
@trisk

LGTM.

trisk commented on commit trisk/crouton@62d2649f1c
@trisk

The "natural scrolling" option in GNOME uses XSetDeviceButtonMapping to alter the XInput button mapping to 1 2 3 5 4 7 6, whereas the default is 1 …

trisk commented on pull request mistifyio/mistify-agent#37
@trisk

Comments from the review on Reviewable.io Reviewed files: cmd/mistify-agent/agent.json @ r3

trisk commented on pull request mistifyio/mistify-agent#37
@trisk

Comments from the review on Reviewable.io Reviewed files: .gitignore @ r1 client/guest.go @ r1 cmd/mistify-agent/agent.json @ r2 config/config.go …

trisk commented on commit trisk/crouton@62d2649f1c
@trisk

You mean the button map on the X input devices we're modifying? That makes sense at a glance and wouldn't be hard to add to this script, though if …

trisk commented on commit trisk/crouton@62d2649f1c
@trisk

Ahhh I'm so sorry, I wasn't aware they were independent of each other. Will revise so that we only launch croutonwheen in the xorg case.

trisk commented on pull request mistifyio/mistify-agent#37
trisk commented on commit trisk/crouton@62d2649f1c
@trisk

This is just blindly enables Australian scrolling and it is inverted compared to normal desktop behaviour. I don't know what the reason for the pol…

trisk commented on commit trisk/crouton@62d2649f1c
@trisk

My touchpad requires cmt dnschneid#713 to function under xorg because the Chromium OS session's cmt leaves it in a mode that only cmt can handle, a…

trisk commented on commit trisk/crouton@62d2649f1c
@trisk

Okay, will provide a heads-up for people already testing the target.

trisk commented on pull request dnschneid/crouton#1302
@trisk

jacklevy#1 PR was done against jacklevy's master branch rather than including the entire cmt target, though I also ended up doing a merge with upst…

trisk created tag 0.0.2 at trisk/coinclip
trisk pushed to master at trisk/coinclip
@trisk
trisk created tag 0.0.1 at trisk/coinclip
trisk pushed to master at trisk/coinclip
@trisk
trisk pushed to master at trisk/coinclip
@trisk
trisk created branch master at trisk/coinclip
trisk created repository trisk/coinclip