Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update p4est JLL package to use v2.8.5 #76

Open
sloede opened this issue Mar 30, 2023 · 3 comments
Open

Update p4est JLL package to use v2.8.5 #76

sloede opened this issue Mar 30, 2023 · 3 comments

Comments

@sloede
Copy link
Member

sloede commented Mar 30, 2023

p4est v2.8.5 was just released. It would be great if we could update the Yggdrasil recipe (and subsequently the JLL package) to use that version as well.

Note: the release tarball is named p4est-2.8.5.5-9ddbb.tar.gz on https://github.com/p4est/p4est.github.io/tree/master/release/, but I think this is still considered to be "p4est v2.8.5" (please correct me if I am wrong, @cburstedde).

@cburstedde
Copy link

Cool! Please note that P4EST_QMAXLEVEL is valid for all quadrant operations except for set_morton and linear_id, for which P4EST_OLD_QMAXLEVEL is the limit. We have added 128 bit alternatives of the latter. The question becomes, shall the linear index type be generally promoted to 128 bit, or shall we reduce the level for set_morton and linear_id?

@sloede
Copy link
Member Author

sloede commented Mar 31, 2023

Thanks for the heads up!

x-ref: DLR-AMR/t8code#498

@sloede
Copy link
Member Author

sloede commented Apr 1, 2023

Let's wait until the issue with the .la files is sorted out before updating the JLL package.

x-ref: DLR-AMR/t8code#496 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants