Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plain-text preview #182

Closed
troeger opened this issue Oct 18, 2017 · 1 comment
Closed

Fix plain-text preview #182

troeger opened this issue Oct 18, 2017 · 1 comment
Milestone

Comments

@troeger
Copy link
Owner

@troeger troeger commented Oct 18, 2017

Although the file preview can now handle plain text uploads, the link in the submission details is still a download link.

@troeger troeger added this to the Next release milestone Oct 18, 2017
@troeger
Copy link
Owner Author

@troeger troeger commented Oct 18, 2017

A quick check also shows that plain text is rendered with syntax higlighting in the preview, which simply makes no sense. There should be some sensible file type detection to deal with that. The most simple solution is to rely on well-known file suffixes to detect code, and make it non-coloured in all other cases.

@troeger troeger closed this in ac342bf Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant