New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not translate exit_status = None to -1 #215

Closed
troeger opened this Issue Jan 10, 2018 · 1 comment

Comments

2 participants
@troeger
Owner

troeger commented Jan 10, 2018

The original test script author tried a student binary that produced a division by zero. Job.run_program() did not throw a Termination exception in this case, but reported a (translated) exit status of -1.

@troeger troeger added this to the v0.7.3 milestone Jan 10, 2018

@tttee tttee self-assigned this Jan 10, 2018

@troeger

This comment has been minimized.

Owner

troeger commented Jan 10, 2018

I can't remember why the exit status is converted, but it may have something to do with the interpretation of the value in the web application. Just correcting the executor code is therefore not enough, the impact on the frontend rendering must also be considered.

@troeger troeger closed this in 56a557c Jan 16, 2018

@troeger troeger added this to the v0.7.3 Release milestone Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment