Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Executor rewrite and new features #144
I have rewritten the locking because of stability of the windows port. I have changed the executor registration code. First attempt was to includes additional environment values in the registration process. Therefor I added a executor value (custom_variables) for reading additional key values pairs from a JSON file.
Generally speaking, this is too much in one pull request. It is at least two of them, one for the new JSON-based environment check configuration, and one for the locking modifications. There would normally be even a third one for the additional server variable being introduced for logging purposes.
The biggest blocker for me is the backward-incompatible change of the configuration file (handling). I trust you with the locking code and assume that you performed some tests on Unix, too.
Time moves on.
The upcoming 0.7.0 release moves OpenSubmit to Python 3.6 only. The executor was completely re-designed as part of this, which makes your pull request more or less invalid.
The rewrite is the starting point to work on all of these issues:
Please note that the locking code is already changed. This might at least solve your Windows problems, but I cannot promise that.
We could still try to take your different changes as proposals for solving the issues listed above. I will check that.