option to enable/disable debugging output #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +19,12 @@ class Api | |||
|
|
|||
| # @private | |||
| def client | |||
|
|
|||
| Savon.configure do |config| | |||
There was a problem hiding this comment.
You're mutating the global state of the Savon and HTTPI classes in a method which is supposed to be called multiple times. This is definitely not the place to do it. A more appropriate place could be after this line, but I still don't think this gem should mutate global state of other gems' main modules.
We should just configure our instance of Savon::Client as described here.
As for HTTPI, I'd not touch it at all, or do it only in the Ecircle.configure method.
The patch could also use some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick modification I made, might be useful for others..