Don't use ActiveModel#has_attribute? due to Rails 4 bug

[ozydingo]

The end result is a confusing error: "ActiveModel::MissingAttributeError: missing attribute: state" due to the following bug in Rails 4:

Job.select("id").first.attribute_names
=> ["state", "id"]

In Rails 5:

Job.select("id").first.attribute_names
=> ["id"]

If code loops through model.attribute_names to display selected values, the error results:

job = Job.select("id").first; job.attribute_names.map{|n| job[n]}
ActiveModel::MissingAttributeError: missing attribute: state

With the current pull request:

job = Job.select("id").first; job.attribute_names.map{|n| job[n]}
=> [1]

The bug can be traced to a bug in Rails 4's has_attribute? method which adds the attribute name to the list even if it was not selected. To support this, since this is the current stable version, we can use attribute_names.include? instead of has_attribute?

[troessner]

Awesome - merged!

I'll release a new version of transitions later today.

Thanks a lot for this contribution!

[troessner]

And 0.2.1 is released.:)

[ozydingo]

Sweet, thanks! That fixed the issue!

On Thu, Aug 20, 2015 at 5:51 AM, Timo Rößner notifications@github.com
wrote:

And 0.2.1 is released.:)

—
Reply to this email directly or view it on GitHub
#144 (comment)
.