Add full write_state_without_persistence implementation #49

Merged
merged 4 commits into from May 2, 2012

Conversation

Projects
None yet
2 participants
@zmillman
Contributor

zmillman commented May 1, 2012

For issue #16

also fixed rdoc formatting typos in README (code should be surrounded by <tt> instead of `s)

@zmillman

This comment has been minimized.

Show comment Hide comment
@zmillman

zmillman May 1, 2012

Contributor

This is also probably worthy of a minor version bump

Contributor

zmillman commented May 1, 2012

This is also probably worthy of a minor version bump

@troessner

This comment has been minimized.

Show comment Hide comment
@troessner

troessner May 1, 2012

hmmm, shouldn't you also test that the state change is not persisted, a.k.a. something like:

assert_equal 'red', @light.reload.state

?

hmmm, shouldn't you also test that the state change is not persisted, a.k.a. something like:

assert_equal 'red', @light.reload.state

?

This comment has been minimized.

Show comment Hide comment
@zmillman

zmillman May 1, 2012

Owner

Good catch, I'll add that

Owner

zmillman replied May 1, 2012

Good catch, I'll add that

troessner added a commit that referenced this pull request May 2, 2012

Merge pull request #49 from zmillman/master
Add full write_state_without_persistence implementation

@troessner troessner merged commit f1d08e7 into troessner:master May 2, 2012

@troessner

This comment has been minimized.

Show comment Hide comment
@troessner

troessner May 2, 2012

Owner

Thanks, there's a new release out there and you are mentioned in the changelog..:-)

Owner

troessner commented May 2, 2012

Thanks, there's a new release out there and you are mentioned in the changelog..:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment