Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Branch: master
Commits on Jan 6, 2015
  1. Cleanup mrouted man page

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. Bump version to 3.9.8-alpha1 to denote development phase.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  3. @DimitryAndric

    Port FreeBSD fix for f72ae3a: mtrace abs() fix with Clang 3.5

    DimitryAndric authored committed
    The following is the commit log from the FreeBSD repository as noted in
    [bug #196166](https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196166):
    
    Fix net/mrouted build (mtrace) with clang 3.5.0
    
    The net/mrouted port fails to compile with clang 3.5.0, due to the
    following -Werror warning:
    
        mtrace.c:923:12: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
                if (*s || abs(ntohl(n->tr_vifout) - ntohl(p->tr_vifout)) > 100000) {
                          ^
        mtrace.c:923:12: note: remove the call to 'abs' since unsigned values cannot be negative
                if (*s || abs(ntohl(n->tr_vifout) - ntohl(p->tr_vifout)) > 100000) {
                          ^~~
        1 error generated.
    
    This is a bug in the code, because the return value of `ntohl()` is
    unsigned, and the difference of two unsigned quantities is still
    unsigned.  However, the intent of the expression is to look at the
    absolute difference between the two quantities.
    
    Therefore, similar to head
    [r274898](https://svnweb.freebsd.org/base?view=revision&revision=274898)
    for rtadvd, introduce a small static function that clarifies the intent,
    and call it instead.
    
    Signed-off-by: Dimitry Andric <dimitry@andric.com>
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  4. @ocochard

    Fix mtrace compilation with Clang 3.5

    ocochard authored committed
    Clang 3.5 adds a new check regarding `unsigned int` used in `abs()`.
    This dirty hack fixes that.
    
    See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196166
    for another fix.
    
    Signed-off-by: Olivier Cochard-Labbé <olivier@cochard.me>
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  5. Free allocated memory, should only be a problem on uClinux or similar

    authored
    The `scan-build` tool (clang) warns about `pfd` not being freed
    on exit from the main loop => free memory, which UNIX usually
    frees itself when collecting the process.  This bug should only
    be a problem on uClinux (no MMU systems).
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  6. Remove unused assignment and clarify check with comment.

    authored
    The `scan-build` tool (clang) warns about `argv` being unused
    after argument parsing is complete => remove assignment and
    clarify in comment why we check the reminder of argc.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Commits on Dec 28, 2014
  1. Update Debian changelog for 3.9.7-1

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. Update ChangeLog and bump version for v3.9.7 release.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  3. Minor cleanups from pimd and whitespace fixes.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Commits on Oct 28, 2014
  1. ChangeLog: More on the FreeBSD fixes :)

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. vif.c:info_version() - Fix Clang complaint on FreeBSD

    authored
    Should remove the need for the following patch in ports:
    
      https://svnweb.freebsd.org/ports/head/net/mrouted/files/patch-vif.c
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  3. icmp.c: Sanity check IP header length before using as array index

    authored
    Coverity CID #71307
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  4. Replace strncpy() with memcpy() to struct ifreq ifnames

    authored
    The strncpy() syscall does not terminate with zero, which in the case of
    struct ifreq interface names does not matter. For shorter names the
    callee should have setup the source string to be NULL terminated. This
    should silence Coverity Scan CID #71281 and #71287.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  5. Cleanup old SYSV references obsoleted by POSIX.1-2001

    authored
    * Replace srand48()/srandom() with srand()
    * Replace lrand48()/random() with rand()
    * Remove setpgrp(), uses setsid() instead
    * Simplify defs.h and remove SYSV define in configure script
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  6. Followup to 26cfdc4, more possible NULL deref by Coverity.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  7. Replace static config.mk with configure script from pimd.

    authored
    No more editing config.mk to build for non-Linux or embedded targets,
    simply run ./configure (with optional arguments) to create a custom
    config.mk for your system.  Imported from pimd.
    
    Also updated ChangeLog a bit.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  8. Makefile: Add make check target using Clang scan-build

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  9. main.c:daemin_pid() - Check return value of fscanf() when reading pid…

    authored
    …file.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  10. Silence scan-build warnings

    authored
    Calling logit() wit LOG_ERR never returns.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  11. prune.c:delete_lclgrp() - Fix possible NULL pointer deref thanks to C…

    authored
    …lang
    
    When g->gt_route i NULL, which the if-clause permits, we may dereference
    a NULL pointer.  Found by scan-build (Clang)
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  12. Fix bad use of ? operator in fprintf(), found by Clang.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  13. Port SOCK_RAW ip_len fixes for older *BSD's from pimd

    authored
    This is a port of the troglobit/pimd#23 patch that was brought
    to my attention by Olivier Cochard-Labbé.  See the FreeBSD help
    at https://wiki.freebsd.org/SOCK_RAW for details.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  14. @gustavoz

    Switch from bcopy to memmove

    gustavoz authored committed
    The bcopy() function is marked as legacy per POSIX.1-2001 and removed by
    POSIX-1.2008 thus shouldn't be used.
    
    Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  15. mrouted.8: Cleanup doc for new options and mess with .conf syntax for…

    authored
    …matting
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  16. README: Cleanup.

    authored
    Slight change in disposition and readability.
    
    Correct section on RSRR, it's been enabled ever since the Debian
    patches were merged -- so there's no need to do anything special
    to activate RSRR anymore.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  17. Minor fixes to authors section in mrouted(8), use .An macro. (author,…

    authored
    … OpenBSD)
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  18. Some simple macro fixes (jmc, OpenBSD)

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  19. Remove unnecessary netinet/in_systm.h include. (OpenBSD)

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  20. Bump version to 3.9.7-rc1

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Commits on Oct 27, 2014
  1. route.c:queue_blaster_report() - Fix invalid use of sizeof() in malloc()

    authored
    Wanted to allocate an int, allocated an int * ... found by Coverity, CID #71300
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. rsrr_read(): Fix invalid use of sizeof() on pointer, should be buffer…

    authored
    … length
    
    Coverity CID #71302
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  3. Revert previous (int) cast.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  4. vif.c:update_neighbor() - Fix uninitialized genid (0)

    authored
    Fixes Coverity CID #71305
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  5. report_next_chunk(): starting route might be NULL, don't report such …

    authored
    …chunks
    
    Coverity Scan CID #71282
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  6. accept_neighbors2(): Fix copy-paste comparison nb_i->threshold != nb_…

    authored
    …i->threshold
    
    Should likely have been nb_i->threshold != nb_n->threshold instead.
    Fixes Coverity Scan CID #71277
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Something went wrong with that request. Please try again.