Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Oct 27, 2014
  1. Fix issue #10: Loop forever on command if daemon not running.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. Makefile.in: Update with new sbin installation path.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Commits on Oct 26, 2014
  1. @bombadil

    Install binaries to /usr/sbin, not /usr/bin

    bombadil authored
    This is more File Hierarchy Standard conform. Only binaries intended for use by
    all users of a (multi-user) system should go to /usr/bin or /bin.
Commits on Sep 30, 2014
  1. Bump version for release of SMCRoute 2.0.0

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. Update release notes for SMCRoute 2.0.0 release.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  3. Add release target with md5 and gpg signing to Makefile

    authored
    Also add SysV init script to doc install and distribution.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Commits on Sep 29, 2014
  1. Fix issue #9: Add SysV init script. Courtesy of Debian.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. Add space before build number in version info.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  3. Fix potential string not NUL terminated bug, Coverity CID #60558

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  4. smcroute.c: Fix potential negative array index write

    authored
    Coverity Scan CID #61536
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  5. Check setsockopt() RC and add more useful messages when mroute socket…

    authored
    … is busy
    
    Fix Coverity Scan CID #60560, #60563
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  6. Attempt to fix autotools version mismatch on newer systems

    authored
    I think it should be like this, '>' == older than:
    
       aclocal.m4 > configure > Makefile.in
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Commits on Sep 28, 2014
  1. Downgrade to automake 1.11 to support Ubuntu 12.04 and Debian 7

    authored
    - Ubuntu 12.04 LTS
    - Debian 7.x LTS
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. Fix issue #6: Convert to fully make use of the GNU Configure and Buil…

    authored
    …d system
    
    Initial conversion from lightweight configure with homegrown Makefile.in
    to using full configure + Makefile.am -- heads up, files may be missing
    from `make dist` or `make install`!
    
    This commit should also fix the last issues with install/unzip mentioned
    in issue #5 -- resulting README and ChangeLog are now copied to archive.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  3. parse-conf.c:add_mroute() - Add missing memset(0) of mroute6_t

    authored
    This missing memset() can cause mroute.ttl[] to have an undefined value
    when later calling mroute6_add().  Fixes Coverity Scan CID #60562.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  4. pidfile(): Update to OpenBSD v1.10, to fix resource leak.

    authored
    Fixes Coverity Scan CID #60564
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  5. Protect against possibly unterminated strings in IPC.

    authored
    Fix Coverity Scan CID #60565.  The received string in `buf`
    may not be NUL terminated.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  6. mroute6_del(): Fix out of bounds access to stack variable.

    authored
    Fix copy-paste bug in mroute6_del(), should use IPv6 address string
    length variable, not IPv4, of course.  Coverity Scan CID #60566.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  7. @bombadil

    Do not hide problems from invoking 'rm -f'

    bombadil authored
    The command 'rm -f' (as defined on line 24) already returns no error if the
    file doesn't exist. But we certainly want the make target to fail if there are
    other errors that let rm fail.
  8. Cleanup and flatten directory structure of this little project.

    authored
    1) This project is too small to motivate several subdirectories
    2) With a simpler Makefile we can target BSD PMake with less effort
    
    This commit is inspired by the discussions in issue #5
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  9. Fix issue #5: Drop bogus use of connect(), fails on FreeBSD

    authored
    For some reason the legacy code to open a local kernel socket for IPv4
    group join/leave (IP_ADD/DROP_MEMBERSHOP) had a completely useless
    connect() statement in it.  It's not needed to do setsockopt() and
    FreeBSD 10 fails on it -- drop code and simplify.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  10. Fix issue #5: Conditionalize Linux anachronism

    authored
    The IPv6 multicast routing proc setting does not exist outside Linux,
    conditionalize it using #ifdef __linux__ (compiler built-in define).
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Commits on Sep 21, 2014
  1. smcroute.c: Fix build errors on FreeBSD

    authored
    The System V calling convention for setpgrp() is not available on
    FreeBSD, replace with equivalent setpgid(0, 0).
    
    Also, fix missing return value in read_mroute6_socket().
    
    Fixes part of smcroute issue #5
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. mroute-api.c: Misc. build fixes for FreeBSD

    authored
    - Fix comment-within-comment Linux/*BSD --> Linux and *BSD
    - Fix 'struct vif' definition --> struct { .. } vif_list[]
    
    Fixes part of smcroute issue #5
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  3. Makefile.in: Cleanup and refactor dep file generation on behalf of Fr…

    authored
    …eeBSD
    
    - Refactor dep file generation using fancy new GCC feature
    - Remove ifneq's around -include, not needed now
    
    Fixes part of smcroute issue #5
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  4. configure: net/route.h needs sys/socket.h on FreeBSD

    authored
    FreeBSD fixes
    - net/route.h needs sys/socket.h (struct sockaddr)
    - netinet/ip_mroute.h needs sys/types.h (u_long et consortes)
    
    Fixes part of smcroute issue #5
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  5. ipc.c: Use standard POSIX error codes instead of Linux centric ones.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Commits on Sep 20, 2014
  1. Last attempt to fix .travis.yml for Coverity Scan

    authored
    I get the following message from Travis when trying to trigger a scan,
    looks like a broken tarball?  My guess is that I've managed to set the
    wrong security token so the tarball is scrambled.  This is the last
    attempt to fix it by diffing with my other projects and verbatim paste
    from the Coverity project page ...
    
        Coverity Scan configured to run on branch master
        Coverity Scan analysis authorized per quota.
        Downloading Coverity Scan Analysis Tool...
        2014-09-20 09:30:24 URL:https://scan.coverity.com/users/sign_in [8576] -> "/tmp/cov-analysis-Linux.tgz" [1]
        Extracting Coverity Scan Analysis Tool...
        /tmp/coverity-scan-analysis ~/build/troglobit/smcroute
        gzip: stdin: not in gzip format
        tar: Child returned status 1
        tar: Error is not recoverable: exiting now
    
      -- https://travis-ci.org/troglobit/smcroute/builds/35798465
    
    If it still doesn't work, then I'm going to assume there's something
    wrong in the interface between Travis and Coverity.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. Update Coverity security token

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  3. Add support for Coverity Scan of SMCRoute master branch

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  4. Change bug report address from my personal email to GitHub issues.

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  5. Markdownify README and ChangeLog and add Travis CI

    authored
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Commits on Apr 19, 2014
  1. @bombadil
Commits on Feb 22, 2014
  1. smclog(): Fix nasty uninitialized variable used in vsnprintf() buf ca…

    authored
    …lculation.
    
    Again, cppcheck found this:
    
        [syslog.c:54]: (error) Uninitialized variable: len
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  2. Fix hidden problem with dynamic interfaces, thanks to cppcheck.

    authored
    The clever cppcheck tool alerted to this:
    
        [smcroute.c:178]: (style) Variable 'iface' is assigned a value that
        is never used.
    
    Turns out there was unfinished code that was supposed to check if
    inbound traffic for (*,G) handling was from an unknown interface.
    
    Add check for unknown interface, possibly dynamically added after
    smcroute was started.  We don't support such interfaces right now,
    but it could easily be added.
    
    For some people it could be useful to instead exit on this error,
    and let a process supervisor restart smcroute so it reenumerates
    and picks up that dynamic interface.
    
    Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Something went wrong with that request. Please try again.