Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Sep 25, 2012
  1. @mikewied

    MB-6661: Mock functions implement new delete api

    mikewied authored Peter Wansch committed
    Change-Id: I260179828d6965d5320239d7e4fc48162c644a40
    Reviewed-on: http://review.couchbase.org/21082
    Reviewed-by: Junyi Xie <junyi.couchbase@gmail.com>
    Reviewed-by: Jin Lim <jin@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Sep 20, 2012
  1. @mikewied

    MB-6661: The delete packet returns a cas value

    mikewied authored Peter Wansch committed
    This is neccessary for clients to detect an update after a delete
    when using the observe command.
    
    Change-Id: I2ed11dedc69346a3cc08d0e65c7db2b9ed7af209
    Reviewed-on: http://review.couchbase.org/20855
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Sep 6, 2012
  1. MB-6237 Remove the python client

    authored
    Change-Id: I5913b9e06d8d5db6f494055b1bcd35e95883665c
    Reviewed-on: http://review.couchbase.org/20584
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Aug 21, 2012
  1. MB-6350: Don't build static archive

    authored
    Change-Id: Ied06bfc564f8f34def2e63f4eb3703b80535f10e
    Reviewed-on: http://review.couchbase.org/19952
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  2. MB-6349: Don't add a version number to the .so

    authored
    Change-Id: I201c737e4a74968d5bfe99f33447bf05911c33c2
    Reviewed-on: http://review.couchbase.org/19951
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  3. MB-6348: Don't build and install the scripts by default

    authored
    They're not used by the server anyway.
    
    Change-Id: I6986d533b2ac9689a1500208132020b98c113928
    Reviewed-on: http://review.couchbase.org/19950
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  4. MB-6347: Move python_wrapper

    authored
    Change-Id: I7d06b4a6cf4cf371b9dc7a3ab2a8b09ce0fd783d
    Reviewed-on: http://review.couchbase.org/19949
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  5. MB-6346: Update the build procedure

    authored
    Change-Id: I75fb08c481e38df4333f89bedf2cef3f6ab7443e
    Reviewed-on: http://review.couchbase.org/19948
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  6. MB-6345: Remove unused file

    authored
    Change-Id: I7014b188d47af5381fbf285bd4be8025621bb602
    Reviewed-on: http://review.couchbase.org/19947
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  7. MB-6344: Remove bdist target

    authored
    Change-Id: Ibc59e4852eaeaff84501bb507742f6dccbc588f8
    Reviewed-on: http://review.couchbase.org/19946
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Aug 17, 2012
  1. @mikewied

    MB-6141: ep-engine command_ids.h is now in include folder

    mikewied authored
    This change makes sure the windows build can find the
    ep-engine include files.
    
    Change-Id: I89183477482858c4affb009b9dff21924e324fc6
    Reviewed-on: http://review.couchbase.org/19732
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Aug 2, 2012
  1. @bcui6611

    MB-6085: Add missing path

    bcui6611 authored committed
    For #include <ep-engine/command_ids.h>, we need to add .. to
    include path to make compiler happy
    
    Change-Id: I624238b18343e515c6d0db81cdeae0b4a553d6a7
    Reviewed-on: http://review.couchbase.org/19205
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  2. @alk

    MB-6089: unbreak build breakage caused by removal of add-with-meta

    alk authored committed
    ep-engine folks recently killed add-with-meta that's not used at all
    for many monthes. So not only we don't need to maintain top keys
    counters for that, but we must remove all references to add-with-meta,
    because corresponding defines are not available anymore.
    
    Change-Id: I6a02239ef06b898dfba80a5df90f1e57d19eaf75
    Reviewed-on: http://review.couchbase.org/19204
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Aug 1, 2012
  1. MB-5879: update topkeys in unknown command

    authored
    Change-Id: Ifd6db74b52be53e6c42eac70e78846af437455a5
    Reviewed-on: http://review.couchbase.org/19079
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  2. MB-6067: Fix compile errors reported with extra warning level

    authored
    Change-Id: Ifb244961931b22e18db06cbfbe06b33e8f9797e8
    Reviewed-on: http://review.couchbase.org/19078
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  3. MB-6065: Fixed EXTRACT_KEY macro

    authored
    Change-Id: I871f99aa83383cc6e89423358f90485cbbf527b0
    Reviewed-on: http://review.couchbase.org/19077
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Jul 3, 2012
  1. MB-5770 fix typo in specfile name

    authored
    Change-Id: Ie65f223b22bc167fcc4587eb473e0eb8cd5184cf
    Reviewed-on: http://review.couchbase.org/17855
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
  2. MB-5770 Add missing files to Makefile.am

    authored
    Change-Id: I55cf4433dd738189bdc0587b196fbd03bc711a29
    Reviewed-on: http://review.couchbase.org/17843
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
Commits on May 16, 2012
  1. @chiyoung

    Modifications due to changes in memcached shutdown

    authored chiyoung committed
    Previously we did not allow multiple calls to handle_disconnect,
    but the new scheme from memcached is that it'll keep on sending
    ON_DISCONNECT every time it detects a change on the connection
    that might lead to a shutdown.
    
    Change-Id: Ic02f814140cd1f12d4002983dd7899225b43ca8e
    Reviewed-on: http://review.couchbase.org/15915
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-on: http://review.couchbase.org/16090
Commits on May 15, 2012
  1. @chiyoung

    MB-3702 Fix the path settings for the wrapper scripts

    authored chiyoung committed
    Forward-port of the patch in 1.8.1
    
    Change-Id: I72be0d4bacf61f057868de7539762eabdc0fc404
    Reviewed-on: http://review.couchbase.org/16019
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Apr 28, 2012
  1. @chiyoung

    MB-5081 Correct the assertion predicate on reserve_cookie()

    chiyoung authored
    The number of clients per bucket is incremented whenever a
    memcached worker thread visits the downstream engine and then
    decremented upon leaving from the downstream engine.
    
    reserve_cookie() function is mainly invoked when a memcached
    worker thread invokes the downstream engine's TAP connection
    API, which means that the number of clients on that bucket is
    greater than zero at the moment of API invocation.
    
    As reserve_cookie() function is also invoked from the separate
    thread in the downstream engine whenever a connection cookie is
    notified to the upstream engine, "number of clients" predicate
    on the assertion check should be greater than equal to zero.
    
    Change-Id: Ie94414f6b89c4b9c20e448cd468e336f89a07961
    Reviewed-on: http://review.couchbase.org/15379
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-on: http://review.couchbase.org/15407
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  2. @chiyoung

    Try to serialize the access the reserve/release methods

    authored chiyoung committed
    Trying to isolate where the race condition problems comes from
    
    Change-Id: I3b136fcff52e068e87800d4a90b032267b046830
    Reviewed-on: http://review.couchbase.org/15350
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-on: http://review.couchbase.org/15406
  3. @chiyoung

    Don't use _that_ long lines

    authored chiyoung committed
    Change-Id: Iee1778439c501c96b1becbb2b69576dfc790fad1
    Reviewed-on: http://review.couchbase.org/15208
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-on: http://review.couchbase.org/15405
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  4. @chiyoung

    Add more tests for bucket_engine

    authored chiyoung committed
    Change-Id: Ic9a81caab58136db8e3b11dc1dbb9fd65f269ce0
    Reviewed-on: http://review.couchbase.org/15207
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-on: http://review.couchbase.org/15404
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  5. @chiyoung

    Replace the "test" make target with the "standard" automake way

    authored chiyoung committed
    The autotools way is to add a check target, causing it to be
    executed by the gmake distcheck target etc.
    
    The "test" target is preserved by creating it as an alias to check
    
    Change-Id: Id2697db9cf85be9d2db0331abd9b18bf92f0b7c6
    Reviewed-on: http://review.couchbase.org/15206
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-on: http://review.couchbase.org/15403
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  6. @chiyoung

    Fix return value from bucket_engine test

    authored chiyoung committed
    Change-Id: I3aa70ba639a50b11964be9386a1c3110d1bd1eb1
    Reviewed-on: http://review.couchbase.org/15161
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-on: http://review.couchbase.org/15402
Commits on Apr 17, 2012
  1. @bcui6611 @chiyoung

    MB-5037 Make bucket-engine tcmalloc aware

    bcui6611 authored chiyoung committed
    We need to make bucket-engine tcmalloc aware even if we don't link
    it with tcmalloc static library.
    
    Change-Id: I20667ed02a57a0e6f4adfb9a9d77229e1909f5b6
    Reviewed-on: http://review.couchbase.org/14913
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Commits on Mar 19, 2012
  1. Fix build to use atomic.h for Sun Studio compilers

    authored
    Change-Id: Ifcd6dd59ae9fe7443706c833e740fbfeabf5cd8c
    Reviewed-on: http://review.couchbase.org/14082
    Tested-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
Commits on Mar 14, 2012
  1. @alk @chiyoung

    also do concurrent bucket deletion test without keeping extra ref

    alk authored chiyoung committed
    Change-Id: I33a5cb4fca19f5a38e5934f02f424c46f424c5a4
    Reviewed-on: http://review.couchbase.org/13912
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  2. @alk @chiyoung

    brutalized concurrent deletion testing

    alk authored chiyoung committed
    Now with (configurably) multiple iterations and many threads.
    
    Change-Id: I599c401d7bd59187ea8dde24965c4d4bd810cd33
    Reviewed-on: http://review.couchbase.org/13911
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  3. @alk @chiyoung

    extracted internal bucket engine structures into internal header

    alk authored chiyoung committed
    So that testapp can do more.
    
    Change-Id: I132ee98f23ed2499b366efcb6358e608d7c378ce
    Reviewed-on: http://review.couchbase.org/13910
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  4. @alk @chiyoung

    correctly prepend CPPFLAGS

    alk authored chiyoung committed
    So that user can always pass own CPPFLAGS (like with -DUSE_GCOV)
    without breaking compilation.
    
    Autoconf standards demand that CPPFLAGS are _not messed up with_.
    
    Change-Id: Ic1a808afe487cdea35ee3d9329738b31e2274e71
    Reviewed-on: http://review.couchbase.org/13909
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  5. @alk @chiyoung

    test-covered deletion of bucket from connection using that bucket

    alk authored chiyoung committed
    Change-Id: Ib1d00b1244b67429465a9e7b175fea41d505bbc6
    Reviewed-on: http://review.couchbase.org/13906
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  6. @alk @chiyoung

    don't try to release_handle on connections of dying bucket

    alk authored chiyoung committed
    There's no need to check reserved for 0 because reserved == 0 means
    connection is disconnected and that implies get_engine_handle cannot
    be called.
    
    release_handle is simply wrong because we keep referring to bucket
    from connection, thus dropping refcount is just wrong.
    
    I was considering set_engine_handle to NULL instead, but that's really
    tricky because we cannot set_engine_handle on reserved connections. So
    it's much easier just to do nothing.
    
    All callers of get_engine_handle will return ENGINE_DISCONNECT on
    get_engine_handle error that'll destroy connection naturally and will
    provide desired effect of encouraging refcount decrement.
    
    Change-Id: I74470aaee664c24da7fb08a1012978cf2a216f34
    Reviewed-on: http://review.couchbase.org/13905
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  7. @alk @chiyoung

    avoid active wait in engine_shutdown_thread

    alk authored chiyoung committed
    We're using shutdown mutex and new condition variable to make shutdown
    thread wait until either refcount drops to 0 or memcached shutdown is
    in progress.
    
    Change-Id: Iaf6b195ed6b4cd1ddade472a45b00d049b6c7308
    Reviewed-on: http://review.couchbase.org/13893
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
    Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Something went wrong with that request. Please try again.