Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apache license violation/Missing reference to bitcoinj project #63

Closed
wongjustin99 opened this issue Jan 16, 2018 · 3 comments
Closed

Apache license violation/Missing reference to bitcoinj project #63

wongjustin99 opened this issue Jan 16, 2018 · 3 comments

Comments

@wongjustin99
Copy link

Similar to #25:

java-tron: https://github.com/tronprotocol/java-tron/blob/develop/src/main/java/org/tron/core/Coin.java
bitcoinj: https://github.com/bitcoinj/bitcoinj/blob/master/core/src/main/java/org/bitcoinj/core/Coin.java

There's many more files from bitcoinj besides the example. All the unmodified pieces need attribution, and the license re-attached (it was stripped out of all the files).
@ac-opensource
Copy link

Provided a fix in this PR: #65

@jromero
Copy link
Contributor

jromero commented Jan 16, 2018

This should be closed as they already addressed these.

@ruchernchong
Copy link
Contributor

Let's ping them. @tronfoundation

@zhaohong zhaohong closed this as completed Feb 2, 2018
zergweak pushed a commit that referenced this issue Jun 18, 2018
@renchenchang
Merge pull request #63 from tronprotocol/evan-addsignapi
6a3c42f 
add getTransactionSign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jromero @wongjustin99 @zhaohong @ac-opensource @ruchernchong and others