Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocksdb22 #2028

Merged
merged 14 commits into from Mar 7, 2019
Merged

Rocksdb22 #2028

merged 14 commits into from Mar 7, 2019

Conversation

@shydesky
Copy link
Contributor

shydesky commented Mar 4, 2019

What does this PR do?
implement db2 with rocksdb
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details
you can find detail of the implement in this link:
tronprotocol/tips#24

@shydesky shydesky requested a review from Yrp Mar 4, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #2028 into develop will increase coverage by 0.11%.
The diff coverage is 56.31%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2028      +/-   ##
============================================
+ Coverage      44.48%   44.6%   +0.11%     
- Complexity      4036    4170     +134     
============================================
  Files            494     505      +11     
  Lines          29041   29845     +804     
  Branches        3022    3111      +89     
============================================
+ Hits           12920   13311     +391     
- Misses         14967   15325     +358     
- Partials        1154    1209      +55
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/tron/core/config/CommonConfig.java 100% <ø> (ø) 1 <0> (ø) ⬇️
src/main/java/org/tron/program/DBConvert.java 0% <0%> (ø) 0 <0> (?)
...rc/main/java/org/tron/core/db2/common/LevelDB.java 91.66% <100%> (ø) 11 <1> (ø) ⬇️
...a/org/tron/common/storage/WriteOptionsWrapper.java 100% <100%> (ø) 3 <3> (?)
...a/org/tron/common/application/ApplicationImpl.java 81.63% <100%> (+0.38%) 13 <1> (ø) ⬇️
...n/core/db2/core/RevokingDBWithCachingNewValue.java 85.07% <100%> (+1.29%) 28 <0> (ø) ⬇️
...main/java/org/tron/core/db2/core/SnapshotRoot.java 88% <100%> (+6.86%) 18 <0> (+1) ⬆️
...n/java/org/tron/core/db2/core/SnapshotManager.java 65.32% <100%> (ø) 49 <0> (ø) ⬇️
...c/main/java/org/tron/core/config/args/Storage.java 73.28% <100%> (+0.84%) 40 <4> (+4) ⬆️
...ava/org/tron/core/db/backup/NeedBeanCondition.java 33.33% <33.33%> (ø) 3 <3> (?)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a3e62...beb9c52. Read the comment docs.

@Yrp
Yrp approved these changes Mar 7, 2019
@Yrp Yrp merged commit 1524d5b into develop Mar 7, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@olenheim olenheim added this to In progress in 3.5.1 via automation Apr 2, 2019
@olenheim olenheim moved this from In progress to Done in 3.5.1 Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3.5.1
  
Done
3 participants
You can’t perform that action at this time.