Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto valid dev #2047

Merged
merged 20 commits into from Apr 11, 2019
Merged

Proto valid dev #2047

merged 20 commits into from Apr 11, 2019

Conversation

@lvs007
Copy link
Contributor

@lvs007 lvs007 commented Mar 14, 2019

What does this PR do?
check the protocol data
Why are these changes required?
Filter out redundant data to ensure storage security

@lvs007 lvs007 requested review from olenheim and wubin12 Mar 14, 2019
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 14, 2019

Codecov Report

Merging #2047 into develop will increase coverage by 0.08%.
The diff coverage is 54.38%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2047      +/-   ##
=============================================
+ Coverage      42.69%   42.77%   +0.08%     
- Complexity      4270     4283      +13     
=============================================
  Files            536      536              
  Lines          32013    32044      +31     
  Branches        3497     3498       +1     
=============================================
+ Hits           13667    13707      +40     
+ Misses         17038    17028      -10     
- Partials        1308     1309       +1
Impacted Files Coverage Δ Complexity Δ
...g/tron/core/net/message/SyncBlockChainMessage.java 18.75% <ø> (ø) 1 <0> (ø) ⬇️
...g/tron/core/net/message/ChainInventoryMessage.java 51.42% <0%> (+1.42%) 6 <0> (ø) ⬇️
...org/tron/core/net/message/TransactionsMessage.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/org/tron/core/net/message/InventoryMessage.java 35.29% <0%> (+1%) 4 <0> (ø) ⬇️
...g/tron/core/net/message/BlockInventoryMessage.java 54.54% <0%> (+2.37%) 3 <0> (ø) ⬇️
.../java/org/tron/core/net/message/BlocksMessage.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/org/tron/core/net/message/BlockMessage.java 47.05% <0%> (+2.61%) 4 <0> (ø) ⬇️
...java/org/tron/core/witness/ProposalController.java 45.29% <0%> (-0.79%) 14 <0> (ø)
src/main/java/org/tron/core/db/Manager.java 42.4% <100%> (+0.05%) 122 <2> (ø) ⬇️
.../main/java/org/tron/core/capsule/BlockCapsule.java 81.59% <100%> (+1.47%) 27 <0> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35eb304...d4b4f1c. Read the comment docs.

Loading

@lvs007 lvs007 added this to the 3.6 milestone Mar 18, 2019
@jiangyy0824 jiangyy0824 added this to Done in 3.6 Apr 2, 2019
@jiangyy0824 jiangyy0824 moved this from Done to Test in 3.6 Apr 2, 2019
@lvs007 lvs007 merged commit dd3d538 into develop Apr 11, 2019
2 checks passed
Loading
3.6 automation moved this from Test to Done Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3.6
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants