Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create2 #2070

Merged
merged 37 commits into from Apr 16, 2019

Conversation

@ithinker1991
Copy link
Contributor

commented Mar 25, 2019

What does this PR do?
A new contract creation function called CREATE2

Why are these changes required?
A new method of creating a contract is proposed where the resulting address can be determined by parties ahead of time.

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up
Extra details

tronprotocol/TIPs#29

ithinker1991 and others added some commits Mar 11, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 26, 2019

Codecov Report

Merging #2070 into develop will increase coverage by 0.11%.
The diff coverage is 58.59%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2070      +/-   ##
=============================================
+ Coverage      44.76%   44.88%   +0.11%     
- Complexity      4173     4211      +38     
=============================================
  Files            503      503              
  Lines          29783    29920     +137     
  Branches        3108     3118      +10     
=============================================
+ Hits           13332    13429      +97     
- Misses         15231    15267      +36     
- Partials        1220     1224       +4
Impacted Files Coverage Δ Complexity Δ
...org/tron/core/actuator/ProposalCreateActuator.java 42.3% <0%> (-1.35%) 23 <0> (ø)
src/main/java/org/tron/core/db/Manager.java 42.92% <0%> (-0.9%) 119 <0> (-1)
...java/org/tron/core/witness/ProposalController.java 49.53% <0%> (-0.95%) 14 <0> (ø)
...g/tron/common/runtime/vm/PrecompiledContracts.java 7.11% <0%> (-0.07%) 2 <0> (ø)
...c/main/java/org/tron/common/runtime/vm/OpCode.java 98.47% <100%> (+0.03%) 17 <0> (ø) ⬇️
src/main/java/org/tron/core/config/Parameter.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...main/java/org/tron/common/runtime/RuntimeImpl.java 63.52% <100%> (+0.27%) 56 <0> (+2) ⬆️
src/main/java/org/tron/core/Wallet.java 14.77% <15.38%> (+0.54%) 45 <1> (+3) ⬆️
src/main/java/org/tron/common/runtime/vm/VM.java 63.33% <52.27%> (+0.59%) 106 <0> (+6) ⬆️
.../java/org/tron/common/runtime/config/VMConfig.java 71.42% <57.14%> (-2.49%) 13 <5> (+2)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a8dc9...9aa7df8. Read the comment docs.

@ithinker1991 ithinker1991 merged commit 9aa7df8 into develop Apr 16, 2019

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@jeancky jeancky added this to the 3.6 milestone May 24, 2019

@jeancky jeancky added this to In progress in 3.6 via automation May 24, 2019

@jeancky jeancky moved this from In progress to Done in 3.6 May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.