Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native eventqueue #2093

Merged
merged 10 commits into from Apr 8, 2019

Conversation

@jiangyy0824
Copy link
Contributor

commented Apr 3, 2019

What does this PR do?
Adding built-in message queue for event subscribe.

Why are these changes required?
Developers could use event plugins to subscribe triggers from fullnode, which provide very reliable service and store very large amount of data.

But in some cases, developers want to subscribe directly from fullnode, with short-term subscriptions. Native message queue is implemented to meet such requirement.

This PR has been tested by:

  • Unit Tests
  • Manual Testing
    Follow up

Extra details

TIP28: tronprotocol/TIPs#28

jiangyy0824 and others added some commits Mar 12, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 3, 2019

Codecov Report

Merging #2093 into develop will increase coverage by 0.09%.
The diff coverage is 20.31%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2093      +/-   ##
=============================================
+ Coverage      43.24%   43.34%   +0.09%     
- Complexity      4026     4045      +19     
=============================================
  Files            511      512       +1     
  Lines          29695    29776      +81     
  Branches        3067     3082      +15     
=============================================
+ Hits           12843    12905      +62     
- Misses         15697    15698       +1     
- Partials        1155     1173      +18
Impacted Files Coverage Δ Complexity Δ
...mon/logsfilter/nativequeue/NativeMessageQueue.java 29.03% <29.03%> (ø) 4 <4> (?)
.../org/tron/common/logsfilter/EventPluginLoader.java 14.28% <3.17%> (-1.79%) 7 <1> (ø)
src/main/java/org/tron/core/config/args/Args.java 61.54% <36%> (-0.42%) 140 <0> (-1)
.../org/tron/common/logsfilter/EventPluginConfig.java 56.52% <66.66%> (+6.52%) 5 <3> (+3) ⬆️
...rg/tron/common/net/udp/handler/MessageHandler.java 89.65% <0%> (-10.35%) 7% <0%> (-1%)
...g/tron/common/overlay/discover/DiscoverServer.java 72.88% <0%> (-8.48%) 6% <0%> (-2%)
src/main/java/org/tron/common/utils/ByteArray.java 53.33% <0%> (-3.34%) 15% <0%> (-1%)
src/main/java/org/tron/core/db/Manager.java 43.27% <0%> (+0.2%) 117% <0%> (+1%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe5ff9...93a928b. Read the comment docs.

@wubinTron wubinTron merged commit 161a3d3 into develop Apr 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jiangyy0824 jiangyy0824 deleted the native_eventqueue branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.