Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix event subscribe to support not abi #2142

Merged
merged 18 commits into from Apr 19, 2019

Conversation

@wubinTron
Copy link
Contributor

commented Apr 18, 2019

What does this PR do?
for event subscribe, a developer is able to upload self ABI to parse the event subscribe.

Why are these changes required?
Developers could use upload himself ABI to parse contract trigger from fullnode, which provides very more freedom for developers.

This PR has been tested by:
local

Extra details
tronprotocol/TIPs#34

wubinTron and others added some commits Apr 1, 2019

@wubinTron wubinTron changed the title Hot fix event plugin Hot fix event subscribe to support not abi Apr 18, 2019

@wubinTron wubinTron changed the title Hot fix event subscribe to support not abi Hotfix event subscribe to support not abi Apr 18, 2019

wubinTron and others added some commits Apr 18, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

Merging #2142 into develop will decrease coverage by 0.04%.
The diff coverage is 29.79%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2142      +/-   ##
=============================================
- Coverage      42.16%   42.12%   -0.05%     
- Complexity      4320     4335      +15     
=============================================
  Files            541      544       +3     
  Lines          32756    32887     +131     
  Branches        3561     3583      +22     
=============================================
+ Hits           13813    13855      +42     
- Misses         17625    17700      +75     
- Partials        1318     1332      +14
Impacted Files Coverage Δ Complexity Δ
...ommon/logsfilter/trigger/ContractEventTrigger.java 61.53% <ø> (ø) 6 <0> (ø) ⬇️
...n/java/org/tron/core/services/http/JsonFormat.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...g/tron/common/runtime/vm/LogInfoTriggerParser.java 14.51% <0%> (+3.4%) 3 <0> (ø) ⬇️
src/main/java/org/tron/core/db/Manager.java 42.55% <0%> (+0.4%) 122 <0> (ø) ⬇️
...ron/common/logsfilter/trigger/ContractTrigger.java 65.21% <0%> (-13.73%) 15 <0> (ø)
...ogsfilter/capsule/ContractEventTriggerCapsule.java 54.54% <0%> (-1.71%) 2 <0> (ø)
...mon/logsfilter/capsule/ContractTriggerCapsule.java 0% <0%> (ø) 0 <0> (?)
src/main/java/org/tron/core/config/args/Args.java 61.94% <100%> (+0.24%) 145 <0> (ø) ⬇️
...rg/tron/common/logsfilter/ContractEventParser.java 56.25% <50%> (-0.65%) 14 <0> (-10)
...ron/common/logsfilter/ContractEventParserJson.java 55% <55%> (ø) 11 <11> (?)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335f525...12369d4. Read the comment docs.

@ithinker1991
Copy link
Contributor

left a comment

LGTM

@wubinTron wubinTron merged commit 12f325e into develop Apr 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.