Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/transfer failed refund #2173

Merged
merged 12 commits into from May 5, 2019
Merged

Feature/transfer failed refund #2173

merged 12 commits into from May 5, 2019

Conversation

@ithinker1991
Copy link
Contributor

@ithinker1991 ithinker1991 commented May 4, 2019

What does this PR do?
not cost all energy when transfer trx or token failed

Why are these changes required?
reduce energy cost

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

@codecov-io codecov-io commented May 4, 2019

Codecov Report

Merging #2173 into develop will increase coverage by 0.07%.
The diff coverage is 85%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2173      +/-   ##
=============================================
+ Coverage      41.41%   41.48%   +0.07%     
- Complexity      4342     4367      +25     
=============================================
  Files            552      552              
  Lines          33478    33517      +39     
  Branches        3655     3664       +9     
=============================================
+ Hits           13866    13906      +40     
- Misses         18277    18293      +16     
+ Partials        1335     1318      -17
Impacted Files Coverage Δ Complexity Δ
...va/org/tron/common/runtime/vm/program/Storage.java 72.5% <ø> (ø) 11 <0> (ø) ⬇️
src/main/java/org/tron/common/runtime/vm/VM.java 65.98% <100%> (+2.33%) 115 <0> (+7) ⬆️
...main/java/org/tron/common/runtime/RuntimeImpl.java 60.77% <100%> (+0.2%) 50 <0> (+2) ⬆️
...c/main/java/org/tron/core/db/TransactionTrace.java 58.13% <100%> (+13.49%) 28 <0> (+10) ⬆️
...va/org/tron/common/runtime/vm/program/Program.java 51.93% <70%> (+2%) 134 <0> (+7) ⬆️
src/main/java/org/tron/core/db/PeersStore.java 17.24% <0%> (-17.25%) 2% <0%> (-2%)
...va/org/tron/common/overlay/discover/node/Node.java 50.84% <0%> (-11.87%) 12% <0%> (-3%)
...n/overlay/discover/node/statistics/Reputation.java 30.23% <0%> (-10.47%) 1% <0%> (-1%)
...tron/common/overlay/discover/node/NodeManager.java 44.02% <0%> (-7.55%) 22% <0%> (-1%)
...tron/common/overlay/discover/node/NodeHandler.java 46.4% <0%> (-6.4%) 17% <0%> (-3%)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc87f2...22c9177. Read the comment docs.

Loading

jeancky
jeancky approved these changes May 5, 2019
@jeancky jeancky merged commit f4851b1 into develop May 5, 2019
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants