Skip to content

Conversation

@lvs007
Copy link
Contributor

@lvs007 lvs007 commented May 28, 2019

What does this PR do?

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@lvs007 lvs007 requested a review from olenheim May 28, 2019 07:40
@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #2255 into develop will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2255      +/-   ##
=============================================
+ Coverage      42.56%   42.56%   +<.01%     
- Complexity      4323     4324       +1     
=============================================
  Files            537      537              
  Lines          32360    32360              
  Branches        3518     3518              
=============================================
+ Hits           13774    13775       +1     
  Misses         17279    17279              
+ Partials        1307     1306       -1
Impacted Files Coverage Δ Complexity Δ
.../accountstate/storetrie/AccountStateStoreTrie.java 31.25% <ø> (ø) 3 <0> (?)
...ava/org/tron/core/db/accountstate/TrieService.java 20% <ø> (ø) 4 <0> (?)
.../tron/core/db/accountstate/AccountStateEntity.java 0% <ø> (ø) 0 <0> (?)
src/main/java/org/tron/core/db/AccountStore.java 90.9% <100%> (ø) 9 <0> (ø) ⬇️
...db/accountstate/callback/AccountStateCallBack.java 20% <100%> (ø) 10 <1> (?)
src/main/java/org/tron/core/db/Manager.java 44.06% <60%> (ø) 116 <0> (ø) ⬇️
.../java/org/tron/common/overlay/server/SyncPool.java 33.84% <0%> (+0.76%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9466c3...2e3306d. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #2255 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2255      +/-   ##
=============================================
+ Coverage      42.56%   42.56%   +<.01%     
  Complexity      4323     4323              
=============================================
  Files            537      537              
  Lines          32360    32360              
  Branches        3518     3518              
=============================================
+ Hits           13774    13775       +1     
  Misses         17279    17279              
+ Partials        1307     1306       -1
Impacted Files Coverage Δ Complexity Δ
.../accountstate/storetrie/AccountStateStoreTrie.java 31.25% <ø> (ø) 3 <0> (?)
...ava/org/tron/core/db/accountstate/TrieService.java 20% <ø> (ø) 4 <0> (?)
src/main/java/org/tron/core/db/AccountStore.java 90.9% <ø> (ø) 9 <0> (ø) ⬇️
.../tron/core/db/accountstate/AccountStateEntity.java 0% <ø> (ø) 0 <0> (?)
src/main/java/org/tron/core/db/Manager.java 44.06% <ø> (ø) 116 <0> (ø) ⬇️
...db/accountstate/callback/AccountStateCallBack.java 20% <100%> (ø) 10 <1> (?)
.../java/org/tron/common/overlay/server/SyncPool.java 33.84% <0%> (+0.76%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9466c3...2e3306d. Read the comment docs.

@lvs007 lvs007 merged commit e9e78b0 into develop May 28, 2019
@lvs007 lvs007 deleted the modify-class-name branch October 15, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants