Skip to content

Conversation

@ithinker1991
Copy link
Contributor

@ithinker1991 ithinker1991 commented Jun 17, 2019

What does this PR do?
set contract result
Why are these changes required?
set contract result

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@ithinker1991 ithinker1991 changed the base branch from develop to master June 17, 2019 10:43
@codecov-io
Copy link

codecov-io commented Jun 17, 2019

Codecov Report

Merging #2312 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2312      +/-   ##
============================================
- Coverage     42.51%   42.49%   -0.03%     
- Complexity     4338     4344       +6     
============================================
  Files           537      537              
  Lines         32483    32522      +39     
  Branches       3562     3576      +14     
============================================
+ Hits          13809    13819      +10     
- Misses        17348    17381      +33     
+ Partials       1326     1322       -4
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/tron/core/db/Manager.java 44.06% <0%> (ø) 116 <0> (ø) ⬇️
...java/org/tron/core/capsule/TransactionCapsule.java 15.89% <0%> (-1.28%) 20 <0> (ø)
...org/tron/core/actuator/ProposalCreateActuator.java 39.28% <0%> (-0.57%) 23 <0> (ø)
src/main/java/org/tron/core/Wallet.java 11.12% <0%> (ø) 34 <0> (ø) ⬇️
...tron/common/overlay/discover/node/NodeManager.java 52.2% <0%> (+0.62%) 25% <0%> (+2%) ⬆️
src/main/java/org/tron/common/utils/ByteArray.java 56.66% <0%> (+3.33%) 16% <0%> (+1%) ⬆️
...g/tron/common/overlay/discover/DiscoverServer.java 82.75% <0%> (+8.62%) 8% <0%> (+2%) ⬆️
...rg/tron/common/net/udp/handler/MessageHandler.java 100% <0%> (+10.34%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae21f6...81111b2. Read the comment docs.

@ithinker1991 ithinker1991 requested a review from taihaofu June 18, 2019 02:53
@BlueHoopor
Copy link
Contributor

continuous-integration/travis-ci/pr failed.
but, QA told me, I should merge this pr, then they can fix this travis problem.

@wangzichichi wangzichichi merged commit 7fe0ed2 into master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants