Skip to content

Conversation

@xxo1shine
Copy link
Contributor

What does this PR do?
optimizing the logic of fast forward node

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

Codecov Report

Merging #2329 into release_3.6.1 will increase coverage by 0.36%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release_3.6.1    #2329      +/-   ##
===================================================
+ Coverage             42.1%   42.47%   +0.36%     
- Complexity            4317     4356      +39     
===================================================
  Files                  538      538              
  Lines                32610    32610              
  Branches              3595     3596       +1     
===================================================
+ Hits                 13730    13850     +120     
+ Misses               17554    17413     -141     
- Partials              1326     1347      +21
Impacted Files Coverage Δ Complexity Δ
.../tron/core/net/messagehandler/BlockMsgHandler.java 21.87% <0%> (-1.21%) 6 <0> (ø)
...ain/java/org/tron/core/net/service/AdvService.java 19.33% <0%> (-0.11%) 11 <0> (-1)
...va/org/tron/common/overlay/discover/node/Node.java 62.71% <0%> (+5.08%) 15% <0%> (+3%) ⬆️
...ay/discover/node/statistics/MessageStatistics.java 51.03% <0%> (+5.51%) 14% <0%> (+4%) ⬆️
...ron/common/net/udp/message/UdpMessageTypeEnum.java 94.11% <0%> (+5.88%) 5% <0%> (+1%) ⬆️
...erlay/discover/node/statistics/NodeStatistics.java 42.85% <0%> (+5.95%) 7% <0%> (ø) ⬇️
...tron/common/overlay/discover/node/NodeManager.java 51.57% <0%> (+6.28%) 23% <0%> (+1%) ⬆️
...g/tron/common/overlay/server/WireTrafficStats.java 90.32% <0%> (+6.45%) 4% <0%> (ø) ⬇️
...tron/common/overlay/discover/table/NodeBucket.java 33.33% <0%> (+9.52%) 3% <0%> (+1%) ⬆️
.../tron/common/overlay/discover/table/NodeTable.java 40% <0%> (+12.3%) 12% <0%> (+4%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450fa28...dcbe050. Read the comment docs.

@xxo1shine xxo1shine merged commit 541210d into release_3.6.1 Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants