Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NullPointerException when a static call throws OutOfTimeException #2407

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@Sh11thead
Copy link
Member

commented Aug 8, 2019

What does this PR do?
check static before setBill function fix the NullPointerException when a static call throws OutOfTimeException
Why are these changes required?
NullPointerException should not appear when static call
This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

Copy link
Contributor

left a comment

LGTM

@Sh11thead Sh11thead merged commit ff4f358 into develop Aug 8, 2019
7 checks passed
7 checks passed
buildkite/build-on-aws-amazon-linux-ami Build #462 passed (16 minutes, 24 seconds)
Details
buildkite/build-on-centos-linux-release-7-dot-4-1708-core Build #424 passed (12 minutes, 47 seconds)
Details
buildkite/build-on-ubuntu-18-dot-04-dot-2 Build #404 passed (17 minutes, 6 seconds)
Details
buildkite/build-on-windows-10 Build #403 passed (14 minutes, 54 seconds)
Details
buildkite/sonar-check Build #416 passed (1 minute, 8 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Sh11thead Sh11thead deleted the fix/fixstaticcallnpexception branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.