Skip to content

Conversation

@Sh11thead
Copy link
Contributor

@Sh11thead Sh11thead commented Aug 28, 2019

What does this PR do?
tronprotocol/tips#54
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

Codecov Report

Merging #2439 into feature/v3.6.5 will decrease coverage by 0.28%.
The diff coverage is 55.81%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             feature/v3.6.5    #2439      +/-   ##
====================================================
- Coverage             42.41%   42.12%   -0.29%     
+ Complexity             4368     4341      -27     
====================================================
  Files                   538      538              
  Lines                 32751    32768      +17     
  Branches               3617     3620       +3     
====================================================
- Hits                  13890    13804      -86     
- Misses                17510    17632     +122     
+ Partials               1351     1332      -19
Impacted Files Coverage Δ Complexity Δ
...in/java/org/tron/common/runtime/vm/EnergyCost.java 75.67% <ø> (ø) 30 <0> (ø) ⬇️
...ntime/vm/program/invoke/ProgramInvokeMockImpl.java 18.82% <0%> (ø) 3 <0> (ø) ⬇️
src/main/java/org/tron/common/runtime/vm/VM.java 65.99% <0%> (ø) 117 <0> (ø) ⬇️
.../tron/common/runtime/vm/program/ContractState.java 22.78% <0%> (-0.3%) 12 <0> (ø)
...g/tron/common/runtime/vm/PrecompiledContracts.java 7.25% <0%> (ø) 3 <0> (ø) ⬇️
...n/runtime/vm/program/invoke/ProgramInvokeImpl.java 66.43% <100%> (+1.36%) 27 <2> (+1) ⬆️
...main/java/org/tron/common/runtime/RuntimeImpl.java 62.98% <77.77%> (+2.36%) 55 <0> (+5) ⬆️
...va/org/tron/common/runtime/vm/program/Program.java 52.02% <77.77%> (+0.85%) 142 <4> (+2) ⬆️
...main/java/org/tron/common/storage/DepositImpl.java 56.33% <85.71%> (+0.54%) 79 <1> (+1) ⬆️
...n/common/net/udp/message/discover/PongMessage.java 0% <0%> (-90%) 0% <0%> (-4%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9885e2d...4d18fe4. Read the comment docs.

BlueHoopor and others added 4 commits August 30, 2019 16:25
…ansfer

# Conflicts:
#	src/main/java/org/tron/common/runtime/vm/PrecompiledContracts.java
#	src/main/java/org/tron/common/runtime/vm/program/Program.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants