Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add load localWitnessAccountAddress for keystore mode #2457

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@sean-liu55
Copy link
Contributor

commented Sep 9, 2019

What does this PR do?
add load localWitnessAccountAddress for keystore mode

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@sean-liu55 sean-liu55 requested a review from zergweak Sep 9, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Sep 9, 2019

Codecov Report

Merging #2457 into develop_v3.6.5 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             develop_v3.6.5    #2457      +/-   ##
====================================================
- Coverage             42.44%   42.43%   -0.01%     
  Complexity             4383     4383              
====================================================
  Files                   538      538              
  Lines                 32818    32825       +7     
  Branches               3633     3635       +2     
====================================================
  Hits                  13928    13928              
- Misses                17534    17541       +7     
  Partials               1356     1356
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/tron/core/config/args/Args.java 61% <0%> (-0.55%) 146 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f8abc...d173284. Read the comment docs.

@renchenchang renchenchang merged commit 0b4b01d into develop_v3.6.5 Sep 9, 2019
7 checks passed
7 checks passed
buildkite/build-on-aws-amazon-linux-ami Build #550 passed (9 minutes, 15 seconds)
Details
buildkite/build-on-centos-linux-release-7-dot-4-1708-core Build #512 passed (9 minutes, 12 seconds)
Details
buildkite/build-on-ubuntu-18-dot-04-dot-2 Build #489 passed (9 minutes, 58 seconds)
Details
buildkite/build-on-windows-10 Build #488 passed (13 minutes, 56 seconds)
Details
buildkite/sonar-check Build #511 passed (13 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.