Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v3.6.5 addvalimutisign #2471

Merged
merged 9 commits into from Sep 18, 2019

Conversation

@Sh11thead
Copy link
Member

commented Sep 18, 2019

What does this PR do?

  • rename multivalidatesign to batchvalidatesign

  • add a new method validatemultisign

tronprotocol/tips#60

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

Sh11thead and others added 9 commits Sep 16, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Sep 18, 2019

Codecov Report

Merging #2471 into develop_v3.6.5 will increase coverage by 0.44%.
The diff coverage is 18.89%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             develop_v3.6.5    #2471      +/-   ##
====================================================
+ Coverage             42.69%   43.13%   +0.44%     
- Complexity             4476     4559      +83     
====================================================
  Files                   545      545              
  Lines                 33277    33754     +477     
  Branches               3694     3841     +147     
====================================================
+ Hits                  14206    14561     +355     
- Misses                17706    17792      +86     
- Partials               1365     1401      +36
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/tron/common/utils/ByteArray.java 48.57% <48.57%> (-8.1%) 16 <16> (ø)
...g/tron/common/runtime/vm/PrecompiledContracts.java 11.55% <7.6%> (+4.53%) 4 <0> (+1) ⬆️
...tron/common/overlay/discover/node/NodeHandler.java 46.4% <0%> (-3.6%) 17% <0%> (ø)
...n/java/org/tron/core/services/ProposalService.java 59.34% <0%> (-1.99%) 46% <0%> (ø)
.../org/tron/common/overlay/discover/RefreshTask.java 100% <0%> (ø) 6% <0%> (+3%) ⬆️
src/main/java/org/tron/core/db/Manager.java 44.6% <0%> (+0.59%) 137% <0%> (+16%) ⬆️
...tron/common/overlay/discover/node/NodeManager.java 52.23% <0%> (+1.03%) 31% <0%> (+10%) ⬆️
.../tron/common/overlay/discover/table/NodeTable.java 40% <0%> (+1.53%) 12% <0%> (+1%) ⬆️
...n/java/org/tron/common/overlay/server/Channel.java 83.1% <0%> (+1.55%) 48% <0%> (+21%) ⬆️
src/main/java/org/tron/core/Wallet.java 13.25% <0%> (+1.6%) 37% <0%> (+2%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227d32e...dd61ad8. Read the comment docs.

@Sh11thead Sh11thead merged commit 2ff7062 into develop_v3.6.5 Sep 18, 2019
7 checks passed
7 checks passed
buildkite/build-on-aws-amazon-linux-ami Build #577 passed (9 minutes, 16 seconds)
Details
buildkite/build-on-centos-linux-release-7-dot-4-1708-core Build #539 passed (10 minutes, 21 seconds)
Details
buildkite/build-on-ubuntu-18-dot-04-dot-2 Build #516 passed (9 minutes, 27 seconds)
Details
buildkite/build-on-windows-10 Build #516 passed (14 minutes, 38 seconds)
Details
buildkite/sonar-check Build #538 passed (13 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.