From 720395a19c566535e9b63e2aa29476eb218cd3d0 Mon Sep 17 00:00:00 2001
From: lvs007 <zy.liang.5@163.com>
Date: Thu, 18 Mar 2021 14:52:05 +0800
Subject: [PATCH] fix sonar error

---
 .../src/main/java/org/tron/core/config/args/Args.java     | 8 ++++----
 framework/src/main/java/org/tron/core/db/Manager.java     | 2 +-
 .../src/main/java/org/tron/core/services/http/Util.java   | 1 -
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/framework/src/main/java/org/tron/core/config/args/Args.java b/framework/src/main/java/org/tron/core/config/args/Args.java
index 61bd844dd15..9187c519f09 100644
--- a/framework/src/main/java/org/tron/core/config/args/Args.java
+++ b/framework/src/main/java/org/tron/core/config/args/Args.java
@@ -746,10 +746,10 @@ public static void setParam(final String[] args, final String confFileName) {
     PARAMETER.historyBalanceLookup = config.hasPath(Constant.HISTORY_BALANCE_LOOKUP) && config
         .getBoolean(Constant.HISTORY_BALANCE_LOOKUP);
 
-    PARAMETER.openPrintLog = config.hasPath(Constant.OPEN_PRINT_LOG) ? config
-        .getBoolean(Constant.OPEN_PRINT_LOG) : true;
-    PARAMETER.openTransactionSort = config.hasPath(Constant.OPEN_TRANSACTION_SORT) ? config
-        .getBoolean(Constant.OPEN_TRANSACTION_SORT) : false;
+    PARAMETER.openPrintLog = config.hasPath(Constant.OPEN_PRINT_LOG) && config
+        .getBoolean(Constant.OPEN_PRINT_LOG);
+    PARAMETER.openTransactionSort = config.hasPath(Constant.OPEN_TRANSACTION_SORT) && config
+        .getBoolean(Constant.OPEN_TRANSACTION_SORT);
 
     logConfig();
   }
diff --git a/framework/src/main/java/org/tron/core/db/Manager.java b/framework/src/main/java/org/tron/core/db/Manager.java
index fdc72661d2f..ccb8342d722 100644
--- a/framework/src/main/java/org/tron/core/db/Manager.java
+++ b/framework/src/main/java/org/tron/core/db/Manager.java
@@ -345,7 +345,7 @@ public void stopRePushTriggerThread() {
     isRunTriggerCapsuleProcessThread = false;
   }
 
-  Comparator downComparator = (Comparator<TransactionCapsule>) (o1, o2) -> Long
+  private Comparator downComparator = (Comparator<TransactionCapsule>) (o1, o2) -> Long
       .compare(o2.getOrder(), o1.getOrder());
 
   @PostConstruct
diff --git a/framework/src/main/java/org/tron/core/services/http/Util.java b/framework/src/main/java/org/tron/core/services/http/Util.java
index b517a0ea1c1..730daaf6223 100644
--- a/framework/src/main/java/org/tron/core/services/http/Util.java
+++ b/framework/src/main/java/org/tron/core/services/http/Util.java
@@ -114,7 +114,6 @@ public static String printTransactionList(TransactionList list, boolean selfType
   }
 
   public static String printTransactionIdList(TransactionIdList list, boolean selfType) {
-    List<String> transactions = list.getTxIdList();
     JSONObject jsonObject = JSONObject.parseObject(JsonFormat.printToString(list, selfType));
 
     return jsonObject.toJSONString();