From 444334bc188ab8aa56f30a4df9ad5adb8a65d1a6 Mon Sep 17 00:00:00 2001 From: neo hong Date: Wed, 15 Dec 2021 15:09:49 +0800 Subject: [PATCH 1/2] fix sonar check --- .../src/main/java/org/tron/core/vm/Op.java | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/actuator/src/main/java/org/tron/core/vm/Op.java b/actuator/src/main/java/org/tron/core/vm/Op.java index 864a11e90b2..d5dc70bbe01 100644 --- a/actuator/src/main/java/org/tron/core/vm/Op.java +++ b/actuator/src/main/java/org/tron/core/vm/Op.java @@ -262,15 +262,15 @@ public class Op { static { Field[] fields = Op.class.getDeclaredFields(); for (Field field : fields) { - if ("int".equals(field.getType().getName())) { - int op = 0; - try { + try { + int op; + if (field.getType() == int.class) { op = field.getInt(Op.class); - } catch (IllegalAccessException e) { - e.printStackTrace(); + OpName[op] = field.getName(); + stringToByteMap.put(field.getName(), (byte) op); } - OpName[op] = field.getName(); - stringToByteMap.put(field.getName(), (byte) op); + } catch (IllegalAccessException e) { + e.printStackTrace(); } } } @@ -286,4 +286,8 @@ public static String getNameOf(byte opCode) { public static byte getOpOf(String opCode) { return stringToByteMap.get(opCode); } + + public static String[] getOpName() { + return OpName; + } } From a5cc7165fb6db7d81a16c5e8b6924a7156aa4782 Mon Sep 17 00:00:00 2001 From: neo hong Date: Wed, 15 Dec 2021 15:12:35 +0800 Subject: [PATCH 2/2] remove unused function --- actuator/src/main/java/org/tron/core/vm/Op.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/actuator/src/main/java/org/tron/core/vm/Op.java b/actuator/src/main/java/org/tron/core/vm/Op.java index d5dc70bbe01..4a2e1a62a8e 100644 --- a/actuator/src/main/java/org/tron/core/vm/Op.java +++ b/actuator/src/main/java/org/tron/core/vm/Op.java @@ -287,7 +287,4 @@ public static byte getOpOf(String opCode) { return stringToByteMap.get(opCode); } - public static String[] getOpName() { - return OpName; - } }