Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): solve 'no need sync' issue reported by nodes #4996

Merged
merged 2 commits into from Feb 16, 2023

Conversation

ss334452
Copy link
Contributor

@ss334452 ss334452 commented Feb 15, 2023

What does this PR do?
solve 'no need sync' issue reported by nodes

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@ss334452 ss334452 changed the title fix(net): solve the problem of reporting 'no need sync' fix(net): solve 'no need sync' issue reported by nodes Feb 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4996 (a82003c) into release_v4.7.1 (a5f9c6f) will decrease coverage by 0.11%.
The diff coverage is 25.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                  @@
##             release_v4.7.1    #4996      +/-   ##
====================================================
- Coverage             54.87%   54.77%   -0.11%     
+ Complexity             8246     8235      -11     
====================================================
  Files                   840      840              
  Lines                 49644    49651       +7     
  Branches               5448     5448              
====================================================
- Hits                  27242    27195      -47     
- Misses                20272    20318      +46     
- Partials               2130     2138       +8     
Impacted Files Coverage Δ
...e/net/messagehandler/ChainInventoryMsgHandler.java 16.66% <0.00%> (-0.73%) ⬇️
...in/java/org/tron/core/net/peer/PeerConnection.java 34.32% <0.00%> (-0.53%) ⬇️
...va/org/tron/core/net/service/sync/SyncService.java 29.82% <66.66%> (+0.23%) ⬆️
...org/tron/core/net/service/nodepersist/DBNodes.java 0.00% <0.00%> (-100.00%) ⬇️
...g/tron/core/exception/DupTransactionException.java 0.00% <0.00%> (-66.67%) ⬇️
...re/net/service/nodepersist/NodePersistService.java 31.81% <0.00%> (-27.28%) ⬇️
...se/src/main/java/org/tron/core/db/CommonStore.java 37.50% <0.00%> (-25.00%) ⬇️
.../java/org/tron/core/consensus/BlockHandleImpl.java 65.00% <0.00%> (-15.00%) ⬇️
...java/org/tron/core/store/WitnessScheduleStore.java 84.84% <0.00%> (-6.07%) ⬇️
...rc/main/java/org/tron/consensus/dpos/DposTask.java 87.09% <0.00%> (-3.23%) ⬇️
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ss334452 ss334452 merged commit 789739b into tronprotocol:release_v4.7.1 Feb 16, 2023
@ss334452 ss334452 deleted the sync branch March 15, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants