feat(all):tune the sequence of resources closure #5447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halibobo1205
force-pushed
the
feat/resources_closure_opt
branch
from
6c1fa19
to
dc8e0bc
Compare
halibobo1205
force-pushed
the
feat/resources_closure_opt
branch
from
1a1a56a
to
9fca4fc
Compare
https://tronscan.org/#/transaction/d7588a4a89bd03b2cfb91141ef312c2b0cdb59f4624f20a0ac6d5c8b8c421be6 |
jwrct
reviewed
Aug 28, 2023
| public class ZksnarkInitService { | ||
|
|
||
| static { | ||
| librustzcashInitZksnarkParams(); |
There was a problem hiding this comment.
When is this method called? The original logic was to call it when the HTTP service is enabled. What would happen if this method is called when the HTTP service is not enabled?
There was a problem hiding this comment.
Better also require the code author to review this change
There was a problem hiding this comment.
What would happen if this method is called when the HTTP service is not enabled?
Prepare to use @DependsOn("fullNodeHttpApiService") to keep the original logic, current guess is delayed initialization.
There was a problem hiding this comment.
@Federico2014 PTAL.
|
| import lombok.extern.slf4j.Slf4j; | ||
| import org.tron.common.parameter.CommonParameter; | ||
|
|
||
| @Slf4j(topic = "app") | ||
| public class ServiceContainer { | ||
|
|
||
| private ArrayList<Service> services; | ||
| private final Set<Service> services; |
There was a problem hiding this comment.
What's the purpose of changing List to Set, if two objects execute init() with the same class and port but without executing start(), they will be equal according to the above modification?
There was a problem hiding this comment.
Yes, block duplicate service.
| } | ||
|
|
||
| @Override | ||
| public void startServices() { | ||
| services.start(); | ||
| } | ||
|
|
||
| @Override | ||
| // DO NOT USE THIS METHOD IN TEST CASES |
There was a problem hiding this comment.
Move this comment below the Override?
| } | ||
|
|
||
| public void blockUntilShutdown() { | ||
| this.services.stream().findFirst().ifPresent(Service::blockUntilShutdown); |
There was a problem hiding this comment.
Only check the first service is stopped?
There was a problem hiding this comment.
blockUntilShutdown synchronously blocks the current thread, usually the main thread.
| @@ -25,7 +25,6 @@ public TronApplicationContext(String... basePackages) { | |||
| public void doClose() { | |||
There was a problem hiding this comment.
As I see, all singletons' close logic was delivered to Spring, is there any dependency between them, or may occur any exceptions when the close order was not as expected?
There was a problem hiding this comment.
The bean dependencies are managed by spring, and initialization and destroy are in reverse order.
halibobo1205
force-pushed
the
feat/resources_closure_opt
branch
from
9fca4fc
to
da66ab8
Compare
No needed. |
tomatoishealthy
approved these changes
Aug 30, 2023
jwrct
approved these changes
Aug 30, 2023
xxo1shine
approved these changes
Aug 30, 2023
fix panicked librustzcash/src/rustzcash.rs:925:9
halibobo1205
force-pushed
the
feat/resources_closure_opt
branch
from
bb83449
to
fc95152
Compare
|
tomatoishealthy
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5433