feat(log/api): separate unexpected and expected logs #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
| @@ -2475,9 +2475,13 @@ public void createShieldedContractParameters( | |||
| ShieldedTRC20Parameters shieldedTRC20Parameters = wallet | |||
| .createShieldedContractParameters(request); | |||
| responseObserver.onNext(shieldedTRC20Parameters); | |||
| } catch (ZksnarkException | ContractValidateException e) { | |||
There was a problem hiding this comment.
What is the purpose of separating exceptions?
According to PR and issue, the purpose is not very clear.
There was a problem hiding this comment.
Unknown exception stacks need to be printed so that you can track down the problem easily.
tomatoishealthy
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #5495