-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(config): fill whole config items #6430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): fill whole config items #6430
Conversation
|
|
||
| ## Configuration flile | ||
| Get the mainnet configuration file: [main_net_config.conf](https://github.com/tronprotocol/tron-deployment/blob/master/main_net_config.conf), other network configuration files can be found [here](https://github.com/tronprotocol/tron-deployment). | ||
| Get the mainnet configuration file: [config.conf](framework/src/main/resources/config.conf), other network configuration files can be found [here](https://github.com/tronprotocol/tron-deployment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use the configuration from the master branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker build needs updating, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a relative path, once it is merged into master, it refers to master's file. tron-deployment will sync from this file later, so docker will do nothing.
|
Please ensure these modifications are also updated in tron-deployment. |
|
Will other config files in |
@Federico2014 Other config files are used for test, so don't need to update. |
Sunny6889
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
No problem. |
waynercheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| # When it is empty,the localwitness is configured with the private key of the witness account. | ||
| # localWitnessAccountAddress = | ||
|
|
||
| localwitness = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to localWitness?
| # ] | ||
|
|
||
| block = { | ||
| needSyncCheck = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needSyncCheck means ?
* fill whole config item * update config.conf * update comment of committee * update comment of storageEnable * add node.rpc.maxRstStream, node.rpc.secondsPerWindow * delete item actuator.whitelist * comments of single line should starts with # * add two items * add config item node.maxTps * add some comments
* fill whole config item * update config.conf * update comment of committee * update comment of storageEnable * add node.rpc.maxRstStream, node.rpc.secondsPerWindow * delete item actuator.whitelist * comments of single line should starts with # * add two items * add config item node.maxTps * add some comments
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details