Skip to content

Conversation

@317787106
Copy link
Contributor

@317787106 317787106 commented Aug 26, 2025

What does this PR do?

  • fill whole config item. Any item not in config.conf is invalid.
  • Full-line comments must start with #.
  • Inline comments can use either # or //.
  • All parameters without default values must start with #.

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details


## Configuration flile
Get the mainnet configuration file: [main_net_config.conf](https://github.com/tronprotocol/tron-deployment/blob/master/main_net_config.conf), other network configuration files can be found [here](https://github.com/tronprotocol/tron-deployment).
Get the mainnet configuration file: [config.conf](framework/src/main/resources/config.conf), other network configuration files can be found [here](https://github.com/tronprotocol/tron-deployment).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the configuration from the master branch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker build needs updating, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a relative path, once it is merged into master, it refers to master's file. tron-deployment will sync from this file later, so docker will do nothing.

@halibobo1205
Copy link
Contributor

Please ensure these modifications are also updated in tron-deployment.

@tronprotocol tronprotocol deleted a comment from mdsabbir9 Aug 27, 2025
@Federico2014
Copy link
Contributor

Will other config files in framework/src/main/resources/ need to be updated?

@kuny0707 kuny0707 linked an issue Aug 27, 2025 that may be closed by this pull request
@317787106
Copy link
Contributor Author

Will other config files in framework/src/main/resources/ need to be updated?

@Federico2014 Other config files are used for test, so don't need to update.

@kuny0707 kuny0707 moved this to In Review in java-tron Aug 28, 2025
Copy link

@Sunny6889 Sunny6889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@317787106
Copy link
Contributor Author

Please ensure these modifications are also updated in tron-deployment.

No problem.

waynercheung

This comment was marked as duplicate.

Copy link
Contributor

@waynercheung waynercheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# When it is empty,the localwitness is configured with the private key of the witness account.
# localWitnessAccountAddress =

localwitness = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to localWitness?

@kuny0707 kuny0707 merged commit b1bf6aa into tronprotocol:release_v4.8.1 Aug 29, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in java-tron Aug 29, 2025
# ]

block = {
needSyncCheck = true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needSyncCheck means ?

halibobo1205 pushed a commit to halibobo1205/java-tron that referenced this pull request Sep 11, 2025
* fill whole config item

* update config.conf

* update comment of committee

* update comment of storageEnable

* add node.rpc.maxRstStream, node.rpc.secondsPerWindow

* delete item actuator.whitelist

* comments of single line should starts with #

* add two items

* add config item node.maxTps

* add some comments
halibobo1205 pushed a commit to halibobo1205/java-tron that referenced this pull request Oct 14, 2025
* fill whole config item

* update config.conf

* update comment of committee

* update comment of storageEnable

* add node.rpc.maxRstStream, node.rpc.secondsPerWindow

* delete item actuator.whitelist

* comments of single line should starts with #

* add two items

* add config item node.maxTps

* add some comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Create Full Configuration File Index directory not created despite correct config and build with -Pindex

9 participants