-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(db/rocksdb): improve resource management with try-with-resources #6472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kuny0707
merged 2 commits into
tronprotocol:release_v4.8.1
from
halibobo1205:feat/rocksdb_opt
Oct 29, 2025
Merged
feat(db/rocksdb): improve resource management with try-with-resources #6472
kuny0707
merged 2 commits into
tronprotocol:release_v4.8.1
from
halibobo1205:feat/rocksdb_opt
Oct 29, 2025
+273
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bladehan1
approved these changes
Oct 24, 2025
Sunny6889
reviewed
Oct 24, 2025
plugins/src/main/java/common/org/tron/plugins/utils/db/RocksDBImpl.java
Outdated
Show resolved
Hide resolved
lvs0075
approved these changes
Oct 24, 2025
63aeed9 to
9be6c52
Compare
Sunny6889
reviewed
Oct 24, 2025
plugins/src/main/java/common/org/tron/plugins/utils/db/RocksDBImpl.java
Outdated
Show resolved
Hide resolved
Sunny6889
reviewed
Oct 24, 2025
plugins/src/main/java/common/org/tron/plugins/utils/db/RocksDBImpl.java
Outdated
Show resolved
Hide resolved
4ab3faf to
ae451fe
Compare
Sunny6889
reviewed
Oct 29, 2025
Sunny6889
approved these changes
Oct 29, 2025
ae451fe to
c8a4314
Compare
waynercheung
approved these changes
Oct 29, 2025
Contributor
waynercheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kuny0707
approved these changes
Oct 29, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves native memory management in RocksDB operations by properly closing
WriteOptionsandReadOptionsobjects using try-with-resources statements.Why are these changes required?
RocksDB Java objects like
WriteOptions,ReadOptions,Options, andRocksIteratorwrap native C++ objects and hold off-heap memory that is not managed by the JVM garbage collector. According to the RocksJava Basics - Memory Management documentation:This PR has been tested by:
Follow up
Extra details
1. Test
Summary
2. reference linking