Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP7.2 compatibility #179

Merged
merged 3 commits into from Dec 4, 2017
Merged

PHP7.2 compatibility #179

merged 3 commits into from Dec 4, 2017

Conversation

@fedeisas
Copy link
Contributor

@fedeisas fedeisas commented Nov 20, 2017

PHP7.2 no longer accepts class names to be Object: https://github.com/php/php-src/blob/php-7.2.0RC6/UPGRADING#L44

@mariano, can you take a look at this as well? Thanks!

@fedeisas
Copy link
Contributor Author

@fedeisas fedeisas commented Dec 4, 2017

@troydavisson could you take a look at this? Thanks.

@troydavisson
Copy link
Owner

@troydavisson troydavisson commented Dec 4, 2017

@fedeisas could we add 7.2 to the .travis.yml file to verify the builds work going forward?

@troydavisson troydavisson self-requested a review Dec 4, 2017
@troydavisson troydavisson merged commit a468b25 into troydavisson:master Dec 4, 2017
1 check passed
@troydavisson
Copy link
Owner

@troydavisson troydavisson commented Dec 4, 2017

Thank you!

@troydavisson
Copy link
Owner

@troydavisson troydavisson commented Dec 4, 2017

I'll try and release a new version that contains this and the related changes (to documentation, etc.) this evening.

@fedeisas
Copy link
Contributor Author

@fedeisas fedeisas commented Dec 4, 2017

@troydavisson no worries, I have some other small changes that (maybe) can make it into the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants