Skip to content

reply closes when pasting non-bmp unicode characters #104

Closed
berdario opened this Issue Mar 18, 2013 · 5 comments

2 participants

@berdario
dario@macbook /t/reply (master) [1]> lein trampoline run 
REPL-y 0.2.0-SNAPSHOT
Clojure 1.4.0
  Exit: Control+D or (exit) or (quit)
Commands: (user/help)
  Docs: (doc function-name-here)
        (find-doc "part-of-name-here")
  Source: (source function-name-here)
        (user/sourcery function-name-here)
 Javadoc: (javadoc java-object-or-class-here)
Examples from clojuredocs.org: [clojuredocs or cdoc]
        (user/clojuredocs name-here)
        (user/clojuredocs "ns-here" "name-here")
user=> "\ud800\udf30"
"REDACTED"
user=> "Bye for now!

at the last line I copied the "REDACTED" and tried to paste it

this does not happen with the standard clojure repl

@berdario

I had to redact away the unicode character, because apparently also github issues itself was crapping in its pants -_-

@berdario

I reported the "github's issues"'s issue to github... and it also happens in these comment boxes...
the javascript console complains about "422 (Unprocessable Entity)"

so, unless they fix it promptly... I'm afraid we will have to avoid mentioning it directly

@trptcolin
Owner

OK, looks like this is jline that's exiting here: sjacket handling is definitely working correctly, and I can reproduce via jline's example client. Fiddling with the encodings for jline's InputStreamReader & OutputStreamWriter (specifically, omitting them and using the defaults) seems to work, but it fails a test for jline and I'm not sure what other implications there are.

@trptcolin trptcolin added a commit that closed this issue Mar 22, 2013
@trptcolin Bump jline for non-BMP characters
closes #104
c03a08a
@trptcolin trptcolin closed this in c03a08a Mar 22, 2013
@trptcolin
Owner

Thanks for the report! This should be all set on master.

@berdario

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.