Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Reply adds commons-logging causing a project slf4j log configuration to be ignored #86

Closed
hugoduncan opened this Issue · 3 comments

2 participants

@hugoduncan

I originally reported this as technomancy/leiningen#690 which has been tagged as upstream, so I am opening this here.

commons-logging is pulled in via cd-client and clj-http.

The only solution I can think of at the moment is to make the cd-client dependency optional somehow.

@trptcolin
Owner

We talked about an API of :repl-options {:cd-client false} in IRC. It should be reasonably straightforward to isolate this dependency. It won't help for other dependencies [in the general case] when running lein trampoline repl, but I'm not sure how that can be fixed at the moment.

@trptcolin
Owner

Yikes, OK: when using the latest cd-client, that commons-logging dependency goes away, but there's still one left, associated with drawbridge.

I guess drawbridge could also be changed to use clj-http-lite to prevent that dependency from creeping in - I'm not sure what differences exist between clj-http and clj-http-lite. And I guess a bigger fix would mean also making drawbridge optional?

colin:reply/ (master) $ lein deps :tree
 [clj-stacktrace "0.2.4"]
 [clojure-complete "0.2.2"]
 [com.cemerick/drawbridge "0.0.6"]
   [clj-http "0.3.6"]
     [org.apache.httpcomponents/httpclient "4.1.2"]
       [commons-logging "1.1.1"]
       [org.apache.httpcomponents/httpcore "4.1.2"]
     [org.apache.httpcomponents/httpmime "4.1.2"]
   [ring/ring-core "1.0.2"]
     [commons-codec "1.4"]
     [commons-fileupload "1.2.1"]
     [commons-io "1.4"]
     [javax.servlet/servlet-api "2.5"]
 [jline "2.8"]
 [org.clojars.trptcolin/sjacket "0.1.1-20120923.070614-1" :exclusions [[org.clojure/clojure]]]
   [net.cgrand/parsley "0.9.1"]
   [net.cgrand/regex "1.1.0"]
 [org.clojure/clojure "1.4.0"]
 [org.clojure/tools.cli "0.2.1"]
 [org.clojure/tools.nrepl "0.2.0-beta9"]
 [org.thnetos/cd-client "0.3.6"]
   [cheshire "4.0.3"]
     [com.fasterxml.jackson.core/jackson-core "2.0.6"]
     [com.fasterxml.jackson.dataformat/jackson-dataformat-smile "2.0.6"]
   [clj-http-lite "0.2.0"]
     [slingshot "0.10.3"]
 [speclj "2.3.0"]
   [fresh "1.0.2"]
   [mmargs "1.2.0"]
 [trptcolin/versioneer "0.1.0"]
@trptcolin
Owner

@hugoduncan Somehow it slipped my mind, but I guess we actually made it legal to run REPLy without access to cd-client awhile back: https://github.com/trptcolin/reply/blob/master/src/clj/reply/initialization.clj#L54-57

And it also looks possible to run without the drawbridge dependency: https://github.com/trptcolin/reply/blob/master/src/clj/reply/eval_modes/nrepl.clj#L118-120

So we might be all set here from a REPLy perspective?

@trptcolin trptcolin closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.