Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #181] Update to nREPL 0.4 #182

Merged
merged 3 commits into from Jun 4, 2018
Merged

[Fix #181] Update to nREPL 0.4 #182

merged 3 commits into from Jun 4, 2018

Conversation

@bbatsov
Copy link
Collaborator

bbatsov commented May 22, 2018

Here's the discussed migration to nREPL 0.4. As you can see the changes are few and trivial. The only real problem is the dependency to drawbridge, which I didn't expect.

I've pinged @cemerick about it nrepl/drawbridge#23

@bbatsov bbatsov force-pushed the bbatsov:new-nrepl branch from f0df406 to a7312c2 May 22, 2018
@bbatsov

This comment has been minimized.

Copy link
Collaborator Author

bbatsov commented May 22, 2018

I'm puzzled by the failures - supposedly I've added properly tools.logging to the setup for the test.

@bbatsov bbatsov force-pushed the bbatsov:new-nrepl branch from a7312c2 to d839026 May 22, 2018
@bbatsov

This comment has been minimized.

Copy link
Collaborator Author

bbatsov commented May 22, 2018

Ah, I found I forgot to update something. OK, the build is officially green then.

bbatsov added 2 commits May 22, 2018
This version depends on the new nREPL 0.4.
@trptcolin trptcolin merged commit 3fb8156 into trptcolin:master Jun 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@trptcolin

This comment has been minimized.

Copy link
Owner

trptcolin commented Jun 4, 2018

👍 thanks!

@bbatsov

This comment has been minimized.

Copy link
Collaborator Author

bbatsov commented Jun 5, 2018

You're welcome! Let me know when you cut a new release, so I can proceed with the rest of the related updates to other projects.

@trptcolin

This comment has been minimized.

Copy link
Owner

trptcolin commented Jun 26, 2018

Released as 0.4.0

@bbatsov

This comment has been minimized.

Copy link
Collaborator Author

bbatsov commented Jun 26, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.