Upgrade bootstrap and fix NPE #28

Open
wants to merge 7 commits into
from

Projects

None yet

3 participants

  • Upgrade Twitter bootstrap to 2.1.0, which solved some IE 8 fussiness I encountered. (davejsmith@a20470f)
  • Prevents an NPE in BeanEditFormVisitor.markErrors() when 'help-inline' class is not found on the element. (davejsmith@a20470f) I can't say I understand what's going on at this level, but there was already a null check, so I moved the offending line down.

There are other changes you may not want. I removed the yuicompressor dependency because it wouldn't resolve from the maven repos that particular day. And added a Windows/Chrome profile for running the tests.

Thanks for the great work on this. My webapp looks/acts so much better with the Bootstrap styling.

-djs

@trsvax trsvax was assigned Sep 24, 2012

I guess, it would be best to send separate pull requests for those issues. That would make it easier to discuss or merge small changes and probably get important fixes (such as a20470f) merges faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment