Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Upgrade bootstrap and fix NPE #28

Open
wants to merge 7 commits into from
+4,354 −2,736

3 participants

@davejsmith
  • Upgrade Twitter bootstrap to 2.1.0, which solved some IE 8 fussiness I encountered. (davejsmith@a20470f)
  • Prevents an NPE in BeanEditFormVisitor.markErrors() when 'help-inline' class is not found on the element. (davejsmith@a20470f) I can't say I understand what's going on at this level, but there was already a null check, so I moved the offending line down.

There are other changes you may not want. I removed the yuicompressor dependency because it wouldn't resolve from the maven repos that particular day. And added a Windows/Chrome profile for running the tests.

Thanks for the great work on this. My webapp looks/acts so much better with the Bootstrap styling.

-djs

@trsvax trsvax was assigned
@jochenberger

I guess, it would be best to send separate pull requests for those issues. That would make it easier to discuss or merge small changes and probably get important fixes (such as a20470f) merges faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 24, 2012
  1. @davejsmith
Commits on Aug 28, 2012
  1. @davejsmith
  2. @davejsmith

    disable yuicompressor for problems resolving

    davejsmith authored
    com.google.code.maven-play-plugin.com.yahoo.platform.yui:yuicompressor:jar:2.4.7.
    Should not be necessary for a module.
Commits on Aug 30, 2012
  1. @davejsmith
Commits on Sep 19, 2012
  1. @davejsmith
  2. @davejsmith
Commits on Oct 6, 2012
  1. @davejsmith
Something went wrong with that request. Please try again.