Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wireshark): rw root fs / hostnet #2389

Merged
merged 5 commits into from Apr 3, 2022
Merged

fix(wireshark): rw root fs / hostnet #2389

merged 5 commits into from Apr 3, 2022

Conversation

stavros-k
Copy link
Member

@stavros-k stavros-k commented Apr 2, 2022 •
edited

Description

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

@stavros-k stavros-k self-assigned this Apr 2, 2022
@truecharts-admin truecharts-admin added the size/XS Categorises a PR that changes 0-9 lines, ignoring generated files. label Apr 2, 2022
@stavros-k
Copy link
Member Author

stavros-k commented Apr 2, 2022 •
edited

  • Bumped heimdal (wasn't bumped on the last PR)
  • Set also the hostNet for zerotier to true on GUI
  • Fixed wireshard ROFS, and also added host net and net_admin cap, also changed port to 3000`
  • switched port on sqlitebrowser with the unused now port of wireshark (10137)

@truecharts-admin truecharts-admin added precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels Apr 2, 2022
@stavros-k stavros-k mentioned this pull request Apr 2, 2022
Closed
11 tasks
@Ornias1993
Copy link
Member

Netadmin should be auto-set by common if hostnet...

@truecharts-admin truecharts-admin added size/S Categorises a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Categorises a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2022
@stavros-k
Copy link
Member Author

Netadmin should be auto-set by common if hostnet...

I could not find any reference for this in common.

I've changed the ports around cause of the hostnetwork

@Ornias1993
Copy link
Member

fixing as we speak:
truecharts/library-charts#30

@stavros-k stavros-k changed the title fix(wireshark): rw root fs / netadmin / hostnet fix(wireshark): rw root fs / hostnet Apr 3, 2022
@Ornias1993 Ornias1993 merged commit 19dd5a2 into truecharts:master Apr 3, 2022
@stavros-k stavros-k deleted the wireshark branch April 3, 2022 14:07
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ornias1993 Ornias1993 Awaiting requested review from Ornias1993 Ornias1993 is a code owner

Assignees

@Ornias1993 Ornias1993

@stavros-k stavros-k

Labels
install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/S Categorises a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stavros-k @Ornias1993 @truecharts-admin