This repository has been archived by the owner on Dec 19, 2017. It is now read-only.
Update schematics #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -139,4 +139,4 @@ def provide(self, model, handler): | |||
|
|
|||
| .. seealso:: :py:mod:`supercell.api.provider.ProviderBase.provide` | |||
| ''' | |||
| handler.write(model.validate()) | |||
| handler.write(model.to_primitive()) | |||
There was a problem hiding this comment.
This means we are not validating the output anymore. Is this intended? I would rather keep the model.validate() line?!
|
added model validation |
|
Merged in 14e630b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the models of schematics 0.9-4 are not compatible with the models of schematics 0.6.0, so this will be a non backwards-compatible change for most projects using supercell, so maybe we need a new 0.x (beta) version for this.