Improve VMware integration in automatic snapshots to support some edge cases#127
Closed
ayavilevich wants to merge 1 commit intotruenas:9.3-STABLEfrom
Closed
Improve VMware integration in automatic snapshots to support some edge cases#127ayavilevich wants to merge 1 commit intotruenas:9.3-STABLEfrom
ayavilevich wants to merge 1 commit intotruenas:9.3-STABLEfrom
Conversation
…e cases. Skips VMs that can't be snapshotted, such as VMs with PCI pass-through devices. Include VMs which have virtual disks on a relevant datastore, but whose configurations are on a different datastore.
Contributor
|
I cherry-picked this into master rather than merging the pull request directly into 9.3-STABLE. The work looks great, thank you for your submission. I'll test it before merging it. |
Contributor
|
This was manually merged into FreeNAS a while ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to address the following issues
Current implementation tries to snapshot all VMs. This raises errors as some VMs can't be snapshotted, such as VMs with pass-through devices.
Snapshots a VM only if the VM's working location is on the datastore. This doesn't snapshot a VM if its virtual disk on a relevant datastore but the working location is on a different datastore.
Only addresses the automatic flow. The manual flow might need to be addressed separately.
More details in https://bugs.freenas.org/issues/13970
Main changes:
Skips VMs that can't be snapshotted, such as VMs with PCI pass-through devices.
Include VMs which have virtual disks on a relevant datastore, but whose configurations are on a different datastore.