NAS-110511 / 21.06 / Bug fixes for setting system birthday #6837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
1 similar comment
themylogin
requested changes
May 5, 2021
sonicaj
force-pushed
the
fix-middleware-start
branch
from
c1ac933
to
63cf259
Compare
yocalebo
reviewed
May 5, 2021
themylogin
approved these changes
May 5, 2021
yocalebo
reviewed
May 5, 2021
yocalebo
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes following issues:
We were trusting that system time would be the correct one, but that may not be the case if
ntpdhas not synced. Changes have been introduced to make sure that we trust the time returned by ntp request if only the clock has synchronized.If we were unable to determine system time, we were waiting for 24 hours before checking again for system birthday which means that we would be storing the incorrect system birthday even when we could potentially save the correct time if we just checked sooner.
Do not unnecessarily have a hook for
interface.post_syncwhen setting system birthday is a one time thing. It will already be ensured that we do set it. So if the first pass failed and interfaces were synced, we will be having another pass after 5 minutes and we will catch up with the correct synced time.