Permalink
Browse files

MFC: 257542

Fix API mismatch exposed by lagg.

When destroying a lagg the driver tries to restore the old mac and
fails due to API mismatch.

Submitted by:   Shahar Klein (shahark at mellanox.com)
Approved by:     re
  • Loading branch information...
1 parent cc8b081 commit 484bf089ba99a2cda5c5538e15ea7a9f7da23d0c @splbio splbio committed Nov 17, 2013
Showing with 2 additions and 2 deletions.
  1. +2 −2 sys/ofed/drivers/net/mlx4/en_netdev.c
View
4 sys/ofed/drivers/net/mlx4/en_netdev.c
@@ -604,8 +604,8 @@ int mlx4_en_start_port(struct net_device *dev)
en_dbg(DRV, priv, "Setting mac for port %d\n", priv->port);
err = mlx4_register_mac(mdev->dev, priv->port,
mlx4_en_mac_to_u64(IF_LLADDR(dev)));
- if (err) {
- en_err(priv, "Failed setting port mac\n");
+ if (err < 0) {
+ en_err(priv, "Failed setting port mac err=%d\n", err);
goto tx_err;
}
mdev->mac_removed[priv->port] = 0;

0 comments on commit 484bf08

Please sign in to comment.